Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
GitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
x/mobile/app: android:screenOrientation is not honored #10943
I have an application with the following AndroidManifest.
@crawshaw while I submitted CL 16150, I don't consider it complete (I think there's a tag the Go team uses for this but I don't recall, this is my first CL). Specifically, testing needs a definitive target and not just whatever's installed on a developers machine as in the CL.
The test should enforce use of a specific build-tool version as a method of declaring the cmd's intended output compatibility.
I considered the current test broken but there are useful bits that should remain describing the format. The comments of
As a frame of reference, I have the following build tool versions installed locally and did a byte compare of manifest output:
All resource identifiers that can not be extracted from gomobile's minimum target (api-9?) should be excluded currently. This concern is a separate issue with gomobile since resource identifiers are hard-coded but contain no information wrt the api level the identifier was introduced. This may lead to invalid manifests containing resource identifiers for an api level higher than the declared target api of a developers manifest. I'm unaware of the defined behaviour in such a case.
This should not affect