Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/build: make temporary logs redirect to permanent logs? #11141

Closed
bradfitz opened this issue Jun 10, 2015 · 2 comments
Closed

x/build: make temporary logs redirect to permanent logs? #11141

bradfitz opened this issue Jun 10, 2015 · 2 comments
Labels
Builders FrozenDueToAge help wanted
Milestone

Comments

@bradfitz
Copy link
Contributor

@bradfitz bradfitz commented Jun 10, 2015

It would be nice if people could share the live-streaming build log URLs and know that they'll always work, regardless of whether they're still live streaming or have completed (even if they're not one of the most recent 30 builds or so which we keep in memory for debugging).

If we recorded a mapping of (builder-id, rev, hexy *buildStatus pointer) => Cloud Storage URL for every build, then if the /temporarylogs handler got a tuple that wasn't in memory, it could then look it up from storage (Cloud Bigtable?) and just redirect the user to the permanent location.

Then we could rename the handler back to simply /logs too.

/cc @adg

@bradfitz bradfitz added this to the Unplanned milestone Jun 10, 2015
@rsc rsc added the Builders label Jun 11, 2015
@nodirt
Copy link
Contributor

@nodirt nodirt commented Sep 4, 2015

FWIU, build logs are stored in Datastore by dashboard permanently, so coordinator can redirect to dashboard, and there is no need for cloud storage/bigtable (unless we want to switch from datastore to cloud storage, but that's a different issue).

Also if we store the (builder-id, rev, hexy *buildStatus pointer) => <something> mapping in coordinator's memory, a restart of the coordinator would lose that info.

Proposal:

  • Dashboard: new handler /result/log/{rev}/{name} searches for Result entity (simple datastore search), retrieves LogHash, retrieves Log and returns the contents of the log (/log handler code will be reused)
  • Coordinator: /temporarylogs handler redirects to the new handler if getStatus returns nil
  • Coordinator: rename /temporarylogs to /logs.

WDYT?

@bradfitz
Copy link
Contributor Author

@bradfitz bradfitz commented Sep 21, 2016

Dup of more aggressive bug: #13076

@golang golang locked and limited conversation to collaborators Sep 21, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Builders FrozenDueToAge help wanted
Projects
None yet
Development

No branches or pull requests

4 participants