Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
testing: Verbose test output has cpu number appended to test name because of GOMAXPROCS default change in Go 1.5; the number lacks an explanation/source/unit #11200
With Go 1.5 the default GOMAXPROCS value has changed:
With Go 1.4.2 tests always ran with
With Go 1.5 the verbose test output has a number appended to the test name:
Some users could wonder where this appended number is coming from...
Theoretically yes, but in case a test fails on one machine and doesn't on another it can take ages to nail it down to a different default GOMAXPROCS value. So I personally would keep
Perhaps the GOMAXPROCS value could be in a parenthetical beside the test
It might make remote debugging (via mail or otherwise) easier.
On 14 June 2015 at 13:24, Rob Pike firstname.lastname@example.org wrote:
referenced this issue
Jun 14, 2015
@robpike Alrighty. My intention for this bug was to fix this Go 1.5 specific issue before Go 1.5 is released. So I only had a very small change in mind...
@adg Great idea but shouldn't this be a separate bug? IMHO details like
We should probably drop the suffix from the test names.
We should keep the suffix in benchmark names.
We should not change the suffix for benchmark names.