Skip to content

/go

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

net/http: HTTPS proxies support #11332

Closed
ailg opened this issue Jun 22, 2015 · 3 comments

Comments

Assignees
No one assigned
Labels
FeatureRequest FrozenDueToAge NeedsFix help wanted
Projects
None yet
Milestone
  Go1.10
6 participants
@ailg @ianlancetaylor @gopherbot @bradfitz @rsc @quentinmit
@ailg
Copy link
Contributor

commented Jun 22, 2015

net/http supports HTTP proxies, where HTTPS is achieved with CONNECT. It would be nice to add support for HTTPS proxies (https://www.chromium.org/developers/design-documents/secure-web-proxy), where the client first establishes a TLS connection to the proxy.

http://tip.golang.org/src/net/http/transport.go?#L754

// Note: no support to https to the proxy yet.

Maybe Transport.DialTLS (http://godoc.org/net/http#Transport) could be used for that. Currently it says:

// DialTLS specifies an optional dial function for creating
// TLS connections for non-proxied HTTPS requests.

@ianlancetaylor ianlancetaylor added this to the Unplanned milestone Jul 11, 2015

@ianlancetaylor

This comment has been minimized.

Sign in to view
Copy link
Contributor

commented Jul 11, 2015

CC @bradfitz

@ailg ailg referenced this issue Feb 10, 2016

Closed

net/http: Transport's automatic http2 too aggressive? #14275

@bradfitz bradfitz modified the milestones: Go1.8, Unplanned Jun 27, 2016

@quentinmit quentinmit added the NeedsFix label Oct 7, 2016

@rsc rsc modified the milestones: Go1.9Early, Go1.8 Oct 26, 2016

@bradfitz bradfitz added FeatureRequest help wanted labels May 3, 2017

@bradfitz bradfitz modified the milestones: Go1.10, Go1.9Early May 3, 2017

@gopherbot

This comment has been minimized.

Sign in to view
Copy link

commented Aug 10, 2017

Change https://golang.org/cl/54770 mentions this issue: net/http: HTTPS proxies support
@gopherbot

This comment has been minimized.

Sign in to view
Copy link

commented Oct 5, 2017

Change https://golang.org/cl/68550 mentions this issue: net/http: HTTPS proxies support

@gopherbot gopherbot closed this in f5cd386 Oct 13, 2017

@bwplotka bwplotka referenced this issue Jan 8, 2018

Open

*: Add support for HTTP CONNECT proxy method. #90

jasonwbarnett pushed a commit to jasonwbarnett/fileserver that referenced this issue Jul 11, 2018

@bemasc @tombergan
net/http: HTTPS proxies support 
net/http already supports http proxies. This CL allows it to establish
a connection to the http proxy over https. See more at:
https://www.chromium.org/developers/design-documents/secure-web-proxy

Fixes golang/go#11332

Change-Id: If0e017df0e8f8c2c499a2ddcbbeb625c8fa2bb6b
Reviewed-on: https://go-review.googlesource.com/68550
Run-TryBot: Tom Bergan <tombergan@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Tom Bergan <tombergan@google.com>
35bb599

@golang golang locked and limited conversation to collaborators Oct 13, 2018

@gopherbot gopherbot added the FrozenDueToAge label Oct 13, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.