Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/mobile/example: all examples are broken on darwin #11424

Closed
rakyll opened this issue Jun 26, 2015 · 6 comments
Closed

x/mobile/example: all examples are broken on darwin #11424

rakyll opened this issue Jun 26, 2015 · 6 comments
Milestone

Comments

@rakyll
Copy link
Contributor

@rakyll rakyll commented Jun 26, 2015

All examples are broken due to golang/mobile@42f0d17 on darwin. I am opening the issue as a reminder to fix the build.

go build golang.org/x/mobile/example/basic
# golang.org/x/mobile/app
../../app/app.go:23: undefined: main
../../app/darwin_amd64.go:58: undefined: mainCalled
../../app/darwin_amd64.go:64: undefined: geom.PixelsPerPt
../../app/darwin_amd64.go:66: undefined: geom.PixelsPerPt
../../app/darwin_amd64.go:68: undefined: configAlt in configAlt.Width
../../app/darwin_amd64.go:68: undefined: geom.PixelsPerPt
../../app/darwin_amd64.go:68: cannot assign to configAlt.Width
../../app/darwin_amd64.go:69: undefined: configAlt in configAlt.Height
../../app/darwin_amd64.go:69: undefined: geom.PixelsPerPt
../../app/darwin_amd64.go:69: cannot assign to configAlt.Height
../../app/darwin_amd64.go:69: too many errors
@rakyll rakyll added this to the Go1.5 milestone Jun 26, 2015
@rakyll rakyll changed the title x/mobile/example: all examples are broken x/mobile/example: all examples are broken on darwin Jun 26, 2015
@nigeltao
Copy link
Contributor

@nigeltao nigeltao commented Jun 26, 2015

In the code review at https://go-review.googlesource.com/#/c/11351/ we (crawshaw and I) agreed that I will break Darwin and crawshaw will fix Darwin.

@nigeltao nigeltao assigned crawshaw and unassigned nigeltao Jun 26, 2015
@crawshaw
Copy link
Member

@crawshaw crawshaw commented Jun 26, 2015

Yes, I'm working on this. There have been a few google-internal distractions today, but I've almost got darwin/amd64 working. I'll send that out, then do darwin/arm{,64}.

@rakyll
Copy link
Contributor Author

@rakyll rakyll commented Jun 30, 2015

Let's make sure they are all working properly at Gophercon. This was an unfortunate time for significant changes.

@crawshaw
Copy link
Member

@crawshaw crawshaw commented Jun 30, 2015

This was fixed several days ago in http://golang.org/cl/11620.

The reason we changed this now was to get the event api we want at the Go 1.5 release in as soon as possible. I'm happy we managed that. It is too bad we didn't find time to rewrite the examples to use it, but anyone trying this before Go 1.5 is stable are working with an experimental package.

@rakyll
Copy link
Contributor Author

@rakyll rakyll commented Jun 30, 2015

Thanks for the update. I have just figured out that my dashboard was red due to an irrelevant problem, the new asset package is broken on darwin/arm.

$ gomobile build -target=ios golang.org/x/mobile/example/audio
main.go:42:2: found packages asset (asset.go) and app (asset_darwin_armx.go) in /Users/jbd/src/golang.org/x/mobile/asset

It is related to your latest change, would you like to take a look at it? Otherwise, I will send mail out a CL.

@gopherbot
Copy link

@gopherbot gopherbot commented Jun 30, 2015

CL https://golang.org/cl/11735 mentions this issue.

crawshaw added a commit to golang/mobile that referenced this issue Jun 30, 2015
Not part of, but mentioned on golang/go#11424.

Change-Id: I9d9289a67592aa43bcd55e073d8f3b29daa93056
Reviewed-on: https://go-review.googlesource.com/11735
Reviewed-by: Burcu Dogan <jbd@google.com>
@golang golang locked and limited conversation to collaborators Jun 29, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants