New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/build: android subrepo builds need to sync data files #11452

Open
mikioh opened this Issue Jun 29, 2015 · 2 comments

Comments

Projects
None yet
4 participants
@mikioh
Contributor

mikioh commented Jun 29, 2015

See http://build.golang.org/log/ec8be097b936c5cf78f7d984ae62d39451ba6dff

go_android_exec: adb shell mkdir -p /data/local/tmp/charset.test-1846
go_android_exec: adb push /tmp/go-build720098852/golang.org/x/net/html/charset/_test/charset.test /data/local/tmp/charset.test-1846/charset.test-1846-tmp
1465 KB/s (3495200 bytes in 2.329s)
go_android_exec: adb shell cp '/data/local/tmp/charset.test-1846/charset.test-1846-tmp' '/data/local/tmp/charset.test-1846/charset.test-1846'
go_android_exec: adb shell rm '/data/local/tmp/charset.test-1846/charset.test-1846-tmp'
go_android_exec: adb shell export TMPDIR="/data/local/tmp/charset.test-1846"; export GOROOT="/data/local/tmp/goroot"; export GOPATH="/data/local/tmp/gopath"; cd "/data/local/tmp/gopath/src/golang.org/x/net/html/charset"; '/data/local/tmp/charset.test-1846/charset.test-1846' -test.short=true; echo -n exitcode=$?
/system/bin/sh: cd: /data/local/tmp/gopath/src/golang.org/x/net/html/charset: No such file or directory

@mikioh mikioh added the OS-Android label Jun 29, 2015

@mikioh mikioh added this to the Go1.5Maybe milestone Jun 29, 2015

@rsc

This comment has been minimized.

Contributor

rsc commented Jun 29, 2015

@crawshaw but pretty sure this is working as intended.

@rsc rsc modified the milestones: Unreleased, Go1.5Maybe Jun 29, 2015

@crawshaw

This comment has been minimized.

Contributor

crawshaw commented Jun 29, 2015

go_android_exec is working as intended. But this could work, with some android-specific handling is needed in the sub-repository builder. In particular, the logic from go/src/androidtest.bash needs to be replicated.

@crawshaw crawshaw changed the title from misc/android: go_android_exec fails to capture sub directories to x/build: android subrepo builds need to sync data files Jun 29, 2015

@crawshaw crawshaw modified the milestones: Go1.6, Unreleased Jun 29, 2015

@rsc rsc modified the milestones: Unreleased, Go1.6 Dec 5, 2015

@gopherbot gopherbot added the Builders label Mar 21, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment