Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/pprof: add --insecure flag to fetch from https endpoints with self signed certificates #11468

Closed
roberthbailey opened this issue Jun 29, 2015 · 3 comments
Milestone

Comments

@roberthbailey
Copy link

@roberthbailey roberthbailey commented Jun 29, 2015

Right now the output looks like:

go tool pprof https://host:port/debug/pprof/profile
Fetching profile from https://host:port/debug/pprof/profile
Please wait... (30s)
http fetch https://host:port/debug/pprof/profile: Get https://host:port/debug/pprof/profile: x509: certificate signed by unknown authority

It would be awesome to be able to pass a --insecure option (like when using curl) so that you don't need to add the self signed certificate to the system's trusted root certificate store to collect profiles.

/cc @bradfitz

@bradfitz bradfitz added this to the Go1.6 milestone Jun 29, 2015
@bradfitz bradfitz changed the title 'go tool pprof' should be able to fetch from https endpoints with a self signed certificate cmd/pprof: add --insecure flag to fetch from https endpoints with self signed certificates Jun 29, 2015
@rsc rsc modified the milestones: Unplanned, Go1.6 Dec 5, 2015
@calavera
Copy link

@calavera calavera commented Mar 19, 2016

FWIW I just submitted a change to fix this issue: https://go-review.googlesource.com/20885

@gopherbot
Copy link

@gopherbot gopherbot commented Mar 19, 2016

CL https://golang.org/cl/20885 mentions this issue.

@gopherbot
Copy link

@gopherbot gopherbot commented Nov 12, 2016

CL https://golang.org/cl/33157 mentions this issue.

@gopherbot gopherbot closed this in 2f49726 Nov 12, 2016
@golang golang locked and limited conversation to collaborators Nov 12, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
5 participants
You can’t perform that action at this time.