Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools/cmd/present: playground output is racy, brought out by new scheduler #11534

Closed
josharian opened this issue Jul 2, 2015 · 3 comments
Closed
Assignees
Milestone

Comments

@josharian
Copy link
Contributor

@josharian josharian commented Jul 2, 2015

race.slide:

Demo

* Hello

.play race.go

race.go:

package main

import "fmt"

func main() {
    fmt.Println("hello, race")
}

Compile present using Go 1.4, open the demo, and hit Run repeatedly. Result: "hello, race" displays consistently.

Compile present using Go tip, open the demo, and hit Run repeatedly. Result: "hello, race" displays maybe one time in three, although the program claims to have exited successfully.

This is probably a logical race in present or playground that the scheduler changes have exposed.

This is probably a high priority, in that I wouldn't want any GopherCon presenters to do a last minute present upgrade and have any unpleasant discoveries.

@josharian josharian added this to the Unreleased milestone Jul 2, 2015
@adg
Copy link
Contributor

@adg adg commented Jul 5, 2015

There was a comment saying "potential race here" right about the culprit
line. Yay past-me?

On 3 July 2015 at 07:03, Josh Bleecher Snyder notifications@github.com
wrote:

Assigned #11534 #11534 to @adg
https://github.com/adg.


Reply to this email directly or view it on GitHub
#11534 (comment).

@gopherbot
Copy link

@gopherbot gopherbot commented Jul 5, 2015

CL https://golang.org/cl/11886 mentions this issue.

adg added a commit to golang/tools that referenced this issue Jul 5, 2015
This doesn't fix the race; doing that would require a bit of a redesign.
Since GopherCon is this week, just put in this stop-gap measure for now.

Update golang/go#11534

Change-Id: Ied6c5dd52778534a7a08b5ba3fa15c0352a65646
Reviewed-on: https://go-review.googlesource.com/11886
Reviewed-by: Josh Bleecher Snyder <josharian@gmail.com>
@adg
Copy link
Contributor

@adg adg commented May 27, 2016

Fixed as part of fixing #11507

@adg adg closed this May 27, 2016
@golang golang locked and limited conversation to collaborators May 27, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.