net: IP.{IsLinkLocalUnicast,IsLinkLocalMulticast,IsGlobalUnicast} false positives

[thockin]

I found this inspecting the code to understand the test.

http://play.golang.org/p/gXdT4o45uw

It looks like those methods are assuming that any IP they get is a 16 byte slice, but as far as I know a 4 byte slice is a valid IP.

[thockin]

Also panic()s if you pass an empty slice (e.g. net.ParseIP("garbage").IsLinkLocalUnicast())

[mikioh]

It's intentional; don't call any methods on a nil value of net.IP.

[gopherbot]

CL https://golang.org/cl/11883 mentions this issue.

[thockin]

Thanks for the fix, looks clean to me.
On Jul 3, 2015 9:59 PM, "Mikio Hara" notifications@github.com wrote:

It's intentional; don't call any methods on a nil value of net.IP.

—
Reply to this email directly or view it on GitHub
#11585 (comment).

[mikioh]

Also IsGlobalUnicast(net.ParseIP("255.255.255.255")).