Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go/types: extend StdSizes to support amd64p32 #11716

Closed
dvyukov opened this issue Jul 14, 2015 · 1 comment
Closed

go/types: extend StdSizes to support amd64p32 #11716

dvyukov opened this issue Jul 14, 2015 · 1 comment
Assignees
Milestone

Comments

@dvyukov
Copy link
Member

@dvyukov dvyukov commented Jul 14, 2015

Currently StdSizes allows to specify only MaxAlignment and WordSize, but this cannot handle one of the standard architectures -- amd64p32. It should allow to specify WordSize and PointerSize independently.

@ianlancetaylor ianlancetaylor added this to the Unplanned milestone Jul 15, 2015
@griesemer
Copy link
Contributor

@griesemer griesemer commented Aug 17, 2016

StdSizes also doesn't exactly follow the gc-compiler's alignment and size computation in general. It's not meant to be a 1:1 drop-in.

What's more, the go/types API and thus StdSizes is frozen. It is easy enough to either a) write an external implementation of Sizes and provide it to go/types, or perhaps add a GCSizes type that matches the gc-behavior exactly. Either way, those approaches would solve this problem in a different way.

I'm going to close this as unfortunate.

Loading

@griesemer griesemer closed this Aug 17, 2016
@golang golang locked and limited conversation to collaborators Aug 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants