Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crypto/x509: TestSystemVerify failed on windows #11730

Closed
chai2010 opened this issue Jul 16, 2015 · 7 comments
Closed

crypto/x509: TestSystemVerify failed on windows #11730

chai2010 opened this issue Jul 16, 2015 · 7 comments

Comments

@chai2010
Copy link
Contributor

@chai2010 chai2010 commented Jul 16, 2015

go version devel +2072fc3 Thu Jul 16 00:57:45 2015 +0000 windows/amd64

--- FAIL: TestSystemVerify (0.08s)
        verify_test.go:389: #15: No expected chain matched BR/Moip Pagamentos
S.A./MOIP,SSL Blindado EV/api.moip.com.br -> GB/COMODO CA Limited//COMODO
RSA Extended Validation Secure Server CA -> GB/COMODO CA Limited//COMODO
RSA Certification Authority

FAIL
@ianlancetaylor ianlancetaylor added this to the Go1.5 milestone Jul 16, 2015
@ianlancetaylor ianlancetaylor changed the title go1.5: TestSystemVerify failed on windows crypto/x509: TestSystemVerify failed on windows Jul 16, 2015
@alexbrainman
Copy link
Member

@alexbrainman alexbrainman commented Jul 19, 2015

@chai2010 what is your OS? From what I understand this test fails on some windows systems and has been disabled there - see https://go-review.googlesource.com/#/c/8167/ for details. Maybe it should be disabled on your too.

Alex

@alexbrainman
Copy link
Member

@alexbrainman alexbrainman commented Jul 20, 2015

@chai2010 I would like to know what your OS version / service pack is. Please "go get" github.com/alexbrainman/winapi and run "go test -run=GetVersion -v" and show command's output here. Thank you.

Alex

@chai2010
Copy link
Contributor Author

@chai2010 chai2010 commented Jul 20, 2015

C:\go\gopkg\src\github.com\alexbrainman\winapi>go test -run=GetVersion -v
=== RUN   TestGetVersionEx
--- PASS: TestGetVersionEx (0.00s)
        winapi_test.go:47: OSVERSIONINFOEX is {OSVersionInfoSize:284 MajorVersion:6
MinorVersion:1 BuildNumber:7601 PlatformId:2 CSDVersion:[83 101 114 118 105 99 101 3
2 80 97 99 107 32 49 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0
 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0
 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0] Se
rvicePackMajor:1 ServicePackMinor:0 SuiteMask:256 ProductType:1 Reserved:0}
        winapi_test.go:48: OSVERSIONINFOEX.CSDVersion is Service Pack 1
PASS
ok      github.com/alexbrainman/winapi  0.092s
@alexbrainman
Copy link
Member

@alexbrainman alexbrainman commented Jul 20, 2015

@chai2010 I can skip this test on your system (see https://go-review.googlesource.com/12401 for details). But that disables the test on all of our builders (and all pcs I have). So we won't know if library code is broken or not. I suggest you try and update your system instead. What do you think?

Alex

@chai2010
Copy link
Contributor Author

@chai2010 chai2010 commented Jul 20, 2015

@alexbrainman Thanks for your work. But i dont use this pkg. And my Win7 is auto updated.

I suggest disable the test (or fix the issue) if it can't run on some system.

@chai2010
Copy link
Contributor Author

@chai2010 chai2010 commented Jul 20, 2015

@alexbrainman We can use a build tag for all builers and all your pcs, just for Go team do test (not for Go user).

@rsc rsc closed this in a502fb2 Jul 22, 2015
@golang golang locked and limited conversation to collaborators Aug 5, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.