Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
GitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
all: golang.org/x repos need to stay green #11811
Some standard library dependencies have changed (packages and files). Both ExampleConfig_CreateFromFiles and ExampleConfig_Import Output needs to be adjusted. Do that. Update golang/go#11811 Change-Id: I523f2adc1aa46f0932a71ccb23dd7c5a6b07fb27 Reviewed-on: https://go-review.googlesource.com/12832 Reviewed-by: Alan Donovan <email@example.com>
The output of ExampleConfig_CreateFromFiles and ExampleConfig_Import are different for Windows that for other platforms: They contain internal/syscall/windows packages and unicode/utf16 not present in the output for other platforms. For golang/go#11811. Change-Id: Id391fbeec8123616da86cb68fc3cefcd513b2493 Reviewed-on: https://go-review.googlesource.com/13032 Reviewed-by: Ian Lance Taylor <firstname.lastname@example.org>
Update golang/go#11811 The increased default concurrency in Go 1.5 showed up a test flake in the TestHostKeyCert test. Under load, when the client provided incorrect data, both sides would race to tear down the connection, which would often lead to the server side, running in its own goroutine to see an unexpected EOF or connection reset. Fix this flake (and the incorrect use of t.Fatalf) by passing the error back to the main goroutine for inspection. This also lets us ignore the expected error in the unsuccessful path Change-Id: I5a95c6d240479e9d537f34177e5ca8023b1b08e9 Reviewed-on: https://go-review.googlesource.com/12916 Reviewed-by: Brad Fitzpatrick <email@example.com>
…empty The builders don't have X. (notably Darwin) Perhaps the Linux ones should. Or some should. Please file a separate bug for that. Somebody else might want to upstream this fix to BurntSushi. Updates golang/go#11811 Change-Id: I6d270a83fc59a3923723b5bfbd0b92057a484a1c Reviewed-on: https://go-review.googlesource.com/12765 Reviewed-by: Nigel Tao <firstname.lastname@example.org>
The generated static.go file was missing a license header when it was created in 2013 in CL 12805046. CL 38165 added a license header, using the current year in the template. This causes the static.go file to go "out of date" whenever the year changes. Change the copyright year to be a fixed year when the file was created. This way, the TestStaticIsUpToDate test will stop breaking every year. Updates golang/go#36360 Updates golang/go#11811 Change-Id: If1597b0d93b7eacf23b7de103a6d7e3ca049bb4f Reviewed-on: https://go-review.googlesource.com/c/tools/+/213119 Run-TryBot: Dmitri Shuralyov <email@example.com> TryBot-Result: Gobot Gobot <firstname.lastname@example.org> Reviewed-by: Rebecca Stambler <email@example.com>
The generated static.go file was created in 2019 in CL 156321, and it inherited the generator code from x/tools that uses today's year. There isn't a need to update the copyright year, so make it a constant. This change fixes the failing TestStaticIsUpToDate test in 2020, and prevents it from breaking in every future year. Fixes golang/go#36360 Updates golang/go#11811 Change-Id: Ie87b1219448f1e288539f95280492b4f95b76798 Reviewed-on: https://go-review.googlesource.com/c/website/+/213121 Run-TryBot: Dmitri Shuralyov <firstname.lastname@example.org> TryBot-Result: Gobot Gobot <email@example.com> Reviewed-by: Rebecca Stambler <firstname.lastname@example.org>
The current GKE tests require to be run on GCE and with Application Default Credentials that have at least the container.clusters.list permission, at least one GKE cluster, and possibly more. The builders that run these tests don't have sufficient permissions, which means these tests never pass. Skip these tests, they can be re-enabled if/when we decide they're worth running automatically and make it possible to do so. Until then, they can be run manually. Updates golang/go#28543 Updates golang/go#11811 Change-Id: Ib76f9d4f93ece2b922c099a21dec4ceefb45b546 Reviewed-on: https://go-review.googlesource.com/c/build/+/215299 Reviewed-by: Alexander Rakoczy <email@example.com> Reviewed-by: Brad Fitzpatrick <firstname.lastname@example.org> Run-TryBot: Alexander Rakoczy <email@example.com> TryBot-Result: Gobot Gobot <firstname.lastname@example.org>
@dmitshur and I have verrified that the subrepos are green for the release branches of golang.org/x repos that are used in the
We are considering the sub repos to be green for the purposes of cutting the go1.14rc1.
…lder The linux-amd64-staticlockranking builder was added pre-emptively so that it could be tested and used during the development of a CL that implements a new feature. It's expected to fail until that work is completed. Mark it as a builder with a known issue, golang/go#38029. The new BuildConfig.KnownIssue field can be used by builders being added in the future so that if they fail at first, it doesn't take away time for people looking at build.golang.org, which we always aim to have as green as possible¹. ¹ https://groups.google.com/d/msg/golang-dev/y0yM_Xi665Q/hUpBiUPiCAAJ Fixes golang/go#38283 For golang/go#38029 For golang/go#37937 For golang/go#11811 Change-Id: Iba1606c7021ffa7e67ddbaae2fc6b65f4e46ab34 Reviewed-on: https://go-review.googlesource.com/c/build/+/227379 Reviewed-by: Alexander Rakoczy <email@example.com>
The golang.org/x repos are green for first-class ports at this time.
The golang.org/x repos need to continue to stay green for the rest of 1.15 release cycle, but this isn't blocking the Go 1.15 Beta 1 release.
Both golang.org/x/exp and golang.org/x/mobile are experimental, and do not support the linux/386 port. Stop running post-submit longtest builds on it. If support for linux/386 is added, tests should start to pass and the builder can be re-enabled then. It appears to have been enabled previously due to a misconfiguration rather than on purpose. Fixes golang/go#39156. For golang/go#29641. For golang/go#11811. Change-Id: I12437880380b9015f6ed9d584db11717f4f024e6 Reviewed-on: https://go-review.googlesource.com/c/build/+/240512 Run-TryBot: Dmitri Shuralyov <firstname.lastname@example.org> TryBot-Result: Gobot Gobot <email@example.com> Reviewed-by: Carlos Amedee <firstname.lastname@example.org>
Creating release branches for Go 1.15 RC1: