New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

all: subrepos need to be green #11811

Open
rsc opened this Issue Jul 21, 2015 · 34 comments

Comments

Projects
None yet
9 participants
@rsc
Contributor

rsc commented Jul 21, 2015

We need to get the subrepos green consistently for 1.5 and moving forward.

@rsc rsc added this to the Go1.5 milestone Jul 21, 2015

gopherbot pushed a commit to golang/tools that referenced this issue Jul 29, 2015

cmd/vet: make TestTags pass on windows
Update golang/go#11811

Change-Id: I3d875acf58a015fa4cae16473a118ac8196b9b44
Reviewed-on: https://go-review.googlesource.com/12789
Reviewed-by: Andrew Gerrand <adg@golang.org>
@gopherbot

This comment has been minimized.

gopherbot commented Jul 29, 2015

CL https://golang.org/cl/12788 mentions this issue.

@gopherbot

This comment has been minimized.

gopherbot commented Jul 29, 2015

CL https://golang.org/cl/12830 mentions this issue.

gopherbot pushed a commit to golang/tools that referenced this issue Jul 29, 2015

cmd/fiximports: make tests pass on windows
Update golang/go#11811

Change-Id: I1f8977cf8eed84936c7c2b568f87abe88f5723f9
Reviewed-on: https://go-review.googlesource.com/12788
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
@gopherbot

This comment has been minimized.

gopherbot commented Jul 29, 2015

CL https://golang.org/cl/12832 mentions this issue.

@gopherbot

This comment has been minimized.

gopherbot commented Jul 29, 2015

CL https://golang.org/cl/12765 mentions this issue.

alandonovan added a commit to golang/tools that referenced this issue Jul 29, 2015

go/loader: update examples Output
Some standard library dependencies have changed (packages and files).
Both ExampleConfig_CreateFromFiles and ExampleConfig_Import Output
needs to be adjusted. Do that.

Update golang/go#11811

Change-Id: I523f2adc1aa46f0932a71ccb23dd7c5a6b07fb27
Reviewed-on: https://go-review.googlesource.com/12832
Reviewed-by: Alan Donovan <adonovan@google.com>

gopherbot pushed a commit to golang/tools that referenced this issue Jul 30, 2015

go/loader: make TestLoad_ParseError_AllowErrors pass on windows
Update golang/go#11811

Change-Id: Ic5f1ea87c88d563b6e0ef2d44042e28a9ea03a03
Reviewed-on: https://go-review.googlesource.com/12830
Reviewed-by: Robert Griesemer <gri@golang.org>
@gopherbot

This comment has been minimized.

gopherbot commented Jul 30, 2015

CL https://golang.org/cl/12838 mentions this issue.

@gopherbot

This comment has been minimized.

gopherbot commented Jul 31, 2015

CL https://golang.org/cl/13008 mentions this issue.

griesemer added a commit to golang/tools that referenced this issue Jul 31, 2015

go/types: exclude some tests when running against Go 1.4
For golang/go#11811.

Change-Id: I130f9608840177cfb7fb9fae30765fcb5aa77411
Reviewed-on: https://go-review.googlesource.com/13008
Reviewed-by: Russ Cox <rsc@golang.org>
@gopherbot

This comment has been minimized.

gopherbot commented Jul 31, 2015

CL https://golang.org/cl/13032 mentions this issue.

@gopherbot

This comment has been minimized.

gopherbot commented Jul 31, 2015

CL https://golang.org/cl/13009 mentions this issue.

griesemer added a commit to golang/tools that referenced this issue Jul 31, 2015

go/ssa/interp: abort long-running test when testing.Short() is set
This should help on slower machines.

For golang/go#11811.

Change-Id: Ibb5d5bf0f6cedcda6437ef0ee3fc1f4ba89dab90
Reviewed-on: https://go-review.googlesource.com/13009
Reviewed-by: Ian Lance Taylor <iant@golang.org>

griesemer added a commit to golang/tools that referenced this issue Jul 31, 2015

go/loader: exclude example tests from Windows tests
The output of ExampleConfig_CreateFromFiles and ExampleConfig_Import
are different for Windows that for other platforms: They contain
internal/syscall/windows packages and unicode/utf16 not present in
the output for other platforms.

For golang/go#11811.

Change-Id: Id391fbeec8123616da86cb68fc3cefcd513b2493
Reviewed-on: https://go-review.googlesource.com/13032
Reviewed-by: Ian Lance Taylor <iant@golang.org>

griesemer added a commit to golang/tools that referenced this issue Jul 31, 2015

cmd/godoc: exclude TestTypeAnalysis on Plan 9 for now
Attempt to make build work on Plan 9.

For golang/go#11811.

Change-Id: I37a5eaef441262342994a8f77c86aa5e120deea7
Reviewed-on: https://go-review.googlesource.com/13033
Reviewed-by: Ian Lance Taylor <iant@golang.org>

griesemer added a commit to golang/tools that referenced this issue Jul 31, 2015

x/tools/cmd/stress: don't build for Plan 9 (syscall.SIGABRT not defined)
See golang/go#11975.
For golang/go#11811.

Change-Id: I56ee20cd798bf963afdf3c81c4745f07850f6dcc
Reviewed-on: https://go-review.googlesource.com/13034
Reviewed-by: Ian Lance Taylor <iant@golang.org>
@gopherbot

This comment has been minimized.

gopherbot commented Aug 1, 2015

CL https://golang.org/cl/12916 mentions this issue.

gopherbot pushed a commit to golang/crypto that referenced this issue Aug 2, 2015

ssh: fix flake in TestHostKeyCert
Update golang/go#11811

The increased default concurrency in Go 1.5 showed up a test flake in
the TestHostKeyCert test. Under load, when the client provided incorrect
data, both sides would race to tear down the connection, which would often
lead to the server side, running in its own goroutine to see an unexpected
EOF or connection reset.

Fix this flake (and the incorrect use of t.Fatalf) by passing the error back
to the main goroutine for inspection. This also lets us ignore the expected
error in the unsuccessful path

Change-Id: I5a95c6d240479e9d537f34177e5ca8023b1b08e9
Reviewed-on: https://go-review.googlesource.com/12916
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>

bradfitz added a commit to golang/exp that referenced this issue Aug 4, 2015

shiny/vendor: make BurntSushi/xgb/xproto tests skip when $DISPLAY is …
…empty

The builders don't have X. (notably Darwin)

Perhaps the Linux ones should. Or some should. Please file a separate bug for that.

Somebody else might want to upstream this fix to BurntSushi.

Updates golang/go#11811

Change-Id: I6d270a83fc59a3923723b5bfbd0b92057a484a1c
Reviewed-on: https://go-review.googlesource.com/12765
Reviewed-by: Nigel Tao <nigeltao@golang.org>
@gopherbot

This comment has been minimized.

gopherbot commented Aug 5, 2015

CL https://golang.org/cl/13252 mentions this issue.

rsc added a commit to golang/text that referenced this issue Aug 5, 2015

cases: skip tests if unicode.Version does not match UnicodeVersion
For golang/go#11811.
Fixes golang/go#11927.

Change-Id: Ie60c687ba93aaeb6c164413289f474be63e0224f
Reviewed-on: https://go-review.googlesource.com/13252
Reviewed-by: Robert Griesemer <gri@golang.org>
@gopherbot

This comment has been minimized.

gopherbot commented Aug 6, 2015

CL https://golang.org/cl/13268 mentions this issue.

griesemer added a commit to golang/tools that referenced this issue Aug 6, 2015

x/tools: disable tests not supported on Android
For golang/go#11811.

Change-Id: Icf16a2d47fcf2fe0d79dd825ccb851a3d63a660f
Reviewed-on: https://go-review.googlesource.com/13268
Reviewed-by: Rob Pike <r@golang.org>
Reviewed-by: David Crawshaw <crawshaw@golang.org>

gopherbot pushed a commit to golang/oauth2 that referenced this issue Oct 7, 2016

oauth2: fix brittle test
A change introduced in https://golang.org/cl/18692 expanded upon the errors
returned by the json package to be more informative about where the error occurred.
This breaks a test in oauth2 that relies on the exact form that an error takes.
Fix this test by simply checking whether it passes or not.

Fixes golang/go#17363
Updates golang/go#11811

Change-Id: I0062dc64fc1a8fd094b14ed1d0b21528edfbb282
Reviewed-on: https://go-review.googlesource.com/30600
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>

@bradfitz bradfitz changed the title from build: subrepos need to be green to all: subrepos need to be green Nov 11, 2016

@gopherbot

This comment has been minimized.

gopherbot commented Dec 10, 2016

CL https://golang.org/cl/34274 mentions this issue.

gopherbot pushed a commit to golang/tools that referenced this issue Dec 10, 2016

go/loader: fix broken tests after context removal from testing package
Updates golang/go#11811
Updates golang/go#18199

Change-Id: I2ce4615653034563a64b9c126651d2a6ce2aef50
Reviewed-on: https://go-review.googlesource.com/34274
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
Reviewed-by: Joe Tsai <thebrokentoaster@gmail.com>
@gopherbot

This comment has been minimized.

gopherbot commented Dec 10, 2016

CL https://golang.org/cl/34275 mentions this issue.

@gopherbot

This comment has been minimized.

gopherbot commented Dec 13, 2016

CL https://golang.org/cl/34288 mentions this issue.

gopherbot pushed a commit to golang/net that referenced this issue Dec 13, 2016

context: deflake tests under Go 1.6
The context tests were flaky under Go 1.6 on Windows. Make them
slower, but make up for the slowness by parallelizing them.

These tests don't run on Go 1.7+ in the subrepo. They were deflaked in
the standard library's context in Go 1.7.

Updates golang/go#11811

Change-Id: I8dc8d9e13e72e87b4444e92d2316dd95bd7d066d
Reviewed-on: https://go-review.googlesource.com/34288
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Ian Lance Taylor <iant@golang.org>

@bradfitz bradfitz modified the milestones: Go1.9, Go1.8 Dec 15, 2016

@bradfitz

This comment has been minimized.

Member

bradfitz commented Dec 15, 2016

Pretty green for Go 1.8.

@broady

This comment has been minimized.

Member

broady commented Jul 17, 2017

Looking green for 1.9.

@bradfitz bradfitz modified the milestones: Go1.10, Go1.9 Jul 18, 2017

@bradfitz

This comment has been minimized.

Member

bradfitz commented Jan 11, 2018

All green for 1.10 except #23166 which is already marked for 1.10. (/cc @alandonovan) So pushing this to bug for reuse in Go 1.11.

@bradfitz bradfitz modified the milestones: Go1.10, Go1.11 Jan 11, 2018

c3mb0 pushed a commit to c3mb0/net that referenced this issue Apr 2, 2018

http2/h2i: disable building h2i on plan9 and solaris
They lack terminal.MakeRaw and terminal.Restore.

Updates golang/go#11811

Change-Id: I1e5d8ca90b2f9c13fe7a6396c2f86e0a5b392b84
Reviewed-on: https://go-review.googlesource.com/18577
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
Reviewed-by: Chris Broadfoot <cbro@golang.org>

c3mb0 pushed a commit to c3mb0/net that referenced this issue Apr 2, 2018

http2: fix flaky TestTransportResPattern_* tests
The test's server was replying with the stream closure before reading
the test client's request body. This should in theory be handled
better (and golang/go#16029 will be kept open to track it), but that's not
what this test was trying to test anyway.

Instead, make the test do things in the expected order so it can
continue to test its original subject reliably. (It was trying to test
all the orders of optional & optionally fragmented headers in responses.)

Updates golang/go#16029 (flaky http2 TestTransportResPattern_*)
Updates golang/go#11811 (subrepos need to be green)

Change-Id: I631730fce5dad598120bb2d1ea8895e39255d711
Reviewed-on: https://go-review.googlesource.com/24970
Reviewed-by: Andrew Gerrand <adg@golang.org>
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
@gopherbot

This comment has been minimized.

gopherbot commented Jul 25, 2018

Change https://golang.org/cl/125816 mentions this issue: godoc: fix tests on Go 1.9

gopherbot pushed a commit to golang/tools that referenced this issue Jul 25, 2018

godoc: fix tests on Go 1.9
Updates golang/go#11811
Updates golang/go#26531

Change-Id: I9cc7daf551b76c3f06b9dd827c5733513c06895e
Reviewed-on: https://go-review.googlesource.com/125816
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Agniva De Sarker <agniva.quicksilver@gmail.com>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
@dmitshur

This comment has been minimized.

Member

dmitshur commented Aug 13, 2018

The x/tools subrepo tests are currently passing on tip but failing on 1.10 and 1.9 according to https://build.golang.org/. The failures are related to the new x/tools/go/packages package have started after x/tools/cmd/callgraph began using it as of CL 128695. See https://build.golang.org/?repo=golang.org%2fx%2ftools.

/cc @alandonovan FYI.

@gopherbot

This comment has been minimized.

gopherbot commented Aug 13, 2018

Change https://golang.org/cl/129175 mentions this issue: cmd/callgraph: temporarily disable failing tests on go1.10

gopherbot pushed a commit to golang/tools that referenced this issue Aug 13, 2018

cmd/callgraph: temporarily disable failing tests on go1.10
go1.10 and earlier versions of go list do not report test main packages.
Furthermore, go/packages has errors in its Imports under go1.10.

The long-term fix is for go/packages to synthesize test main packages
when working with older versions of the go command, but in the
meantime we will disable the tests.

Updates golang/go#11811

Change-Id: Ifd5e37d5b68a01134e911fda90e30a39fc25b88d
Reviewed-on: https://go-review.googlesource.com/129175
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>

@andybons andybons modified the milestones: Go1.11, Go1.12 Aug 25, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment