Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

all: user-facing golang.org/x repos need to stay green #11811

Open
rsc opened this issue Jul 21, 2015 · 85 comments
Open

all: user-facing golang.org/x repos need to stay green #11811

rsc opened this issue Jul 21, 2015 · 85 comments
Labels
NeedsFix The path to resolution is known, but the work has not been done. recurring Issues that should never be closed, but moved to the next milestone once fixed in the current one. release-blocker
Milestone
Go1.22

Comments

@rsc
Copy link
Contributor

rsc commented Jul 21, 2015 •
edited by heschi

We need to get the subrepos green consistently for 1.5 and moving forward.

edit 2023-06-23 by @heschi:
Modules that are vendored into the main release, such as net and sys, as well as user-facing libraries like tools and text, must be healthy before a release can be issued. Other modules are out of scope.
@rsc rsc added this to the Go1.5 milestone Jul 21, 2015
gopherbot pushed a commit to golang/tools that referenced this issue Jul 29, 2015
@alexbrainman
cmd/vet: make TestTags pass on windows
7ba2a8c 
Update golang/go#11811

Change-Id: I3d875acf58a015fa4cae16473a118ac8196b9b44
Reviewed-on: https://go-review.googlesource.com/12789
Reviewed-by: Andrew Gerrand <adg@golang.org>
@gopherbot
Copy link

CL https://golang.org/cl/12788 mentions this issue.

@gopherbot
Copy link

CL https://golang.org/cl/12830 mentions this issue.

gopherbot pushed a commit to golang/tools that referenced this issue Jul 29, 2015
@alexbrainman
cmd/fiximports: make tests pass on windows
0cac9d8 
Update golang/go#11811

Change-Id: I1f8977cf8eed84936c7c2b568f87abe88f5723f9
Reviewed-on: https://go-review.googlesource.com/12788
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
@gopherbot
Copy link

CL https://golang.org/cl/12832 mentions this issue.

@gopherbot
Copy link

CL https://golang.org/cl/12765 mentions this issue.

This was referenced Jul 29, 2015
Closed
Closed
Closed
Closed
alandonovan pushed a commit to golang/tools that referenced this issue Jul 29, 2015
@alexbrainman @adonovan
go/loader: update examples Output
166a111 
Some standard library dependencies have changed (packages and files).
Both ExampleConfig_CreateFromFiles and ExampleConfig_Import Output
needs to be adjusted. Do that.

Update golang/go#11811

Change-Id: I523f2adc1aa46f0932a71ccb23dd7c5a6b07fb27
Reviewed-on: https://go-review.googlesource.com/12832
Reviewed-by: Alan Donovan <adonovan@google.com>
gopherbot pushed a commit to golang/tools that referenced this issue Jul 30, 2015
@alexbrainman
go/loader: make TestLoad_ParseError_AllowErrors pass on windows
f25d013 
Update golang/go#11811

Change-Id: Ic5f1ea87c88d563b6e0ef2d44042e28a9ea03a03
Reviewed-on: https://go-review.googlesource.com/12830
Reviewed-by: Robert Griesemer <gri@golang.org>
@gopherbot
Copy link

CL https://golang.org/cl/12838 mentions this issue.

@bradfitz bradfitz mentioned this issue Jul 30, 2015
Closed
@gopherbot
Copy link

CL https://golang.org/cl/13008 mentions this issue.

griesemer added a commit to golang/tools that referenced this issue Jul 31, 2015
@griesemer
go/types: exclude some tests when running against Go 1.4
fe546a3 
For golang/go#11811.

Change-Id: I130f9608840177cfb7fb9fae30765fcb5aa77411
Reviewed-on: https://go-review.googlesource.com/13008
Reviewed-by: Russ Cox <rsc@golang.org>
@gopherbot
Copy link

CL https://golang.org/cl/13032 mentions this issue.

@gopherbot
Copy link

CL https://golang.org/cl/13009 mentions this issue.

griesemer added a commit to golang/tools that referenced this issue Jul 31, 2015
@griesemer
go/ssa/interp: abort long-running test when testing.Short() is set
784fe34 
This should help on slower machines.

For golang/go#11811.

Change-Id: Ibb5d5bf0f6cedcda6437ef0ee3fc1f4ba89dab90
Reviewed-on: https://go-review.googlesource.com/13009
Reviewed-by: Ian Lance Taylor <iant@golang.org>
griesemer added a commit to golang/tools that referenced this issue Jul 31, 2015
@griesemer
go/loader: exclude example tests from Windows tests
50fdc6b 
The output of ExampleConfig_CreateFromFiles and ExampleConfig_Import
are different for Windows that for other platforms: They contain
internal/syscall/windows packages and unicode/utf16 not present in
the output for other platforms.

For golang/go#11811.

Change-Id: Id391fbeec8123616da86cb68fc3cefcd513b2493
Reviewed-on: https://go-review.googlesource.com/13032
Reviewed-by: Ian Lance Taylor <iant@golang.org>
griesemer added a commit to golang/tools that referenced this issue Jul 31, 2015
@griesemer
cmd/godoc: exclude TestTypeAnalysis on Plan 9 for now
32dcbb4 
Attempt to make build work on Plan 9.

For golang/go#11811.

Change-Id: I37a5eaef441262342994a8f77c86aa5e120deea7
Reviewed-on: https://go-review.googlesource.com/13033
Reviewed-by: Ian Lance Taylor <iant@golang.org>
griesemer added a commit to golang/tools that referenced this issue Jul 31, 2015
@griesemer
x/tools/cmd/stress: don't build for Plan 9 (syscall.SIGABRT not defined)
5a6a7b4 
See golang/go#11975.
For golang/go#11811.

Change-Id: I56ee20cd798bf963afdf3c81c4745f07850f6dcc
Reviewed-on: https://go-review.googlesource.com/13034
Reviewed-by: Ian Lance Taylor <iant@golang.org>
@gopherbot
Copy link

CL https://golang.org/cl/12916 mentions this issue.

gopherbot pushed a commit to golang/crypto that referenced this issue Aug 2, 2015
@davecheney
ssh: fix flake in TestHostKeyCert
77de70a 
Update golang/go#11811

The increased default concurrency in Go 1.5 showed up a test flake in
the TestHostKeyCert test. Under load, when the client provided incorrect
data, both sides would race to tear down the connection, which would often
lead to the server side, running in its own goroutine to see an unexpected
EOF or connection reset.

Fix this flake (and the incorrect use of t.Fatalf) by passing the error back
to the main goroutine for inspection. This also lets us ignore the expected
error in the unsuccessful path

Change-Id: I5a95c6d240479e9d537f34177e5ca8023b1b08e9
Reviewed-on: https://go-review.googlesource.com/12916
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
bradfitz added a commit to golang/exp that referenced this issue Aug 4, 2015
@bradfitz @nigeltao
shiny/vendor: make BurntSushi/xgb/xproto tests skip when $DISPLAY is …
b77eeee 
…empty

The builders don't have X. (notably Darwin)

Perhaps the Linux ones should. Or some should. Please file a separate bug for that.

Somebody else might want to upstream this fix to BurntSushi.

Updates golang/go#11811

Change-Id: I6d270a83fc59a3923723b5bfbd0b92057a484a1c
Reviewed-on: https://go-review.googlesource.com/12765
Reviewed-by: Nigel Tao <nigeltao@golang.org>
@gopherbot
Copy link

CL https://golang.org/cl/13252 mentions this issue.

rsc added a commit to golang/text that referenced this issue Aug 5, 2015
@rsc
cases: skip tests if unicode.Version does not match UnicodeVersion
083de50 
For golang/go#11811.
Fixes golang/go#11927.

Change-Id: Ie60c687ba93aaeb6c164413289f474be63e0224f
Reviewed-on: https://go-review.googlesource.com/13252
Reviewed-by: Robert Griesemer <gri@golang.org>
@gopherbot
Copy link

CL https://golang.org/cl/13268 mentions this issue.

griesemer added a commit to golang/tools that referenced this issue Aug 6, 2015
@griesemer
x/tools: disable tests not supported on Android
958ab4f 
For golang/go#11811.

Change-Id: Icf16a2d47fcf2fe0d79dd825ccb851a3d63a660f
Reviewed-on: https://go-review.googlesource.com/13268
Reviewed-by: Rob Pike <r@golang.org>
Reviewed-by: David Crawshaw <crawshaw@golang.org>
@gopherbot gopherbot removed the okay-after-beta1 Used by release team to mark a release-blocker issue as okay to resolve either before or after beta1 label Jun 10, 2022
@heschi
Copy link
Contributor

heschi commented Jul 6, 2022

Creating internal-branch.go1.19-vendor branches for the following repos:

arch fc48f9fe4c15
crypto 403b01795ae8
text b4bca84b0361
mod 86c51ed26bb4
net 183a9ca12b87
sync 0976fa681c29
sys 6c1b26c55098
term e5f449aeb171
tools 1e55371df567

@dmitshur
Copy link
Contributor

dmitshur commented Aug 1, 2022

Moving to 1.20.

@dmitshur dmitshur modified the milestones: Go1.19, Go1.20 Aug 1, 2022
snapbakkhfbav added a commit to snapbakkhfbav/SayedBaladohr that referenced this issue Oct 6, 2022
@snapbakkhfbav
webp: mark package as requiring Go 1.6 for NYCbCrA
c971f5b 
See https://build.golang.org/log/1e0572f27630c3a896f17722d89b6cc35d9f52d8

Updates golang/go#11811

Change-Id: I0db67f2c8586b1c36608c6131c803eb26fb87751
Reviewed-on: https://go-review.googlesource.com/24945
Reviewed-by: Andrew Gerrand <adg@golang.org>
MiderWong5ddop added a commit to MiderWong5ddop/sidie88f that referenced this issue Oct 7, 2022
@MiderWong5ddop
webp: mark package as requiring Go 1.6 for NYCbCrA
6833d37 
See https://build.golang.org/log/1e0572f27630c3a896f17722d89b6cc35d9f52d8

Updates golang/go#11811

Change-Id: I0db67f2c8586b1c36608c6131c803eb26fb87751
Reviewed-on: https://go-review.googlesource.com/24945
Reviewed-by: Andrew Gerrand <adg@golang.org>
rorypeckwnt4v added a commit to rorypeckwnt4v/LearnByBhanuPrataph that referenced this issue Oct 7, 2022
@rorypeckwnt4v
webp: mark package as requiring Go 1.6 for NYCbCrA
3bb54f9 
See https://build.golang.org/log/1e0572f27630c3a896f17722d89b6cc35d9f52d8

Updates golang/go#11811

Change-Id: I0db67f2c8586b1c36608c6131c803eb26fb87751
Reviewed-on: https://go-review.googlesource.com/24945
Reviewed-by: Andrew Gerrand <adg@golang.org>
egorovcharenko9 added a commit to egorovcharenko9/RiceBIOC470z that referenced this issue Oct 7, 2022
@egorovcharenko9
webp: mark package as requiring Go 1.6 for NYCbCrA
e9a00d8 
See https://build.golang.org/log/1e0572f27630c3a896f17722d89b6cc35d9f52d8

Updates golang/go#11811

Change-Id: I0db67f2c8586b1c36608c6131c803eb26fb87751
Reviewed-on: https://go-review.googlesource.com/24945
Reviewed-by: Andrew Gerrand <adg@golang.org>
RafayGhafoorf added a commit to RafayGhafoorf/dustinsand8 that referenced this issue Oct 7, 2022
@RafayGhafoorf
webp: mark package as requiring Go 1.6 for NYCbCrA
ec9614e 
See https://build.golang.org/log/1e0572f27630c3a896f17722d89b6cc35d9f52d8

Updates golang/go#11811

Change-Id: I0db67f2c8586b1c36608c6131c803eb26fb87751
Reviewed-on: https://go-review.googlesource.com/24945
Reviewed-by: Andrew Gerrand <adg@golang.org>
passionSeven added a commit to passionSeven/website that referenced this issue Oct 18, 2022
@passionSeven
content/static: generate constant 2019 copyright year
56e992c 
The generated static.go file was created in 2019 in CL 156321, and
it inherited the generator code from x/tools that uses today's year.
There isn't a need to update the copyright year, so make it a constant.

This change fixes the failing TestStaticIsUpToDate test in 2020,
and prevents it from breaking in every future year.

Fixes golang/go#36360
Updates golang/go#11811

Change-Id: Ie87b1219448f1e288539f95280492b4f95b76798
Reviewed-on: https://go-review.googlesource.com/c/website/+/213121
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Rebecca Stambler <rstambler@golang.org>
codegod2222 added a commit to codegod2222/oauth_go that referenced this issue Nov 25, 2022
@codegod2222
google: fix the build when appengine isn't present
e964723 
See https://build.golang.org/log/c3e046245c4eafbb7b2571ef9ac144b0d29ba2b5

Updates golang/go#11811

Change-Id: I16d2ac26dcda123e1bd8c456e490f6ca45111d24
Reviewed-on: https://go-review.googlesource.com/24946
Reviewed-by: Andrew Gerrand <adg@golang.org>
Reviewed-by: Chris Broadfoot <cbro@golang.org>
codegod2222 added a commit to codegod2222/oauth_go that referenced this issue Nov 25, 2022
@codegod2222
oauth2: fix brittle test
fbf66fb 
A change introduced in https://golang.org/cl/18692 expanded upon the errors
returned by the json package to be more informative about where the error occurred.
This breaks a test in oauth2 that relies on the exact form that an error takes.
Fix this test by simply checking whether it passes or not.

Fixes golang/go#17363
Updates golang/go#11811

Change-Id: I0062dc64fc1a8fd094b14ed1d0b21528edfbb282
Reviewed-on: https://go-review.googlesource.com/30600
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
@prattmic
Copy link
Member

prattmic commented Dec 7, 2022

Creating internal-branch.go1.20-vendor branches for the following repos:

arch 1bb480fc256a
crypto 2c476679df9a
mod 7c05a442b7c1 # v0.7.0
net 1e63c2f08a10
sync 8fcdb60fdcc0 # v0.1.0
sys 3ca3b18c8b9b # v0.3.0
term f72a2d8d642d # v0.2.0
text c8236a6712b1 # v0.5.0
tools 060c049c4674

@prattmic prattmic added the okay-after-rc1 Used by release team to mark a release-blocker issue as okay to resolve either before or after rc1 label Dec 7, 2022
@gopherbot gopherbot removed the okay-after-rc1 Used by release team to mark a release-blocker issue as okay to resolve either before or after rc1 label Dec 7, 2022
@dmitshur dmitshur mentioned this issue Jan 6, 2023
Closed
@mknyszek
Copy link
Contributor

Moving to 1.21.

@mknyszek mknyszek modified the milestones: Go1.20, Go1.21 Jan 30, 2023
@bcmills
Copy link
Member

bcmills commented Mar 1, 2023

The pkgsite-metrics repo is consistently failing on several builders (#58581), and has been for quite some time.

@bcmills bcmills mentioned this issue Apr 13, 2023
Closed
@prattmic
Copy link
Member

Creating internal-branch.go1.21-vendor branches for the following repos:

arch 40c19ba4a7c5 # v0.3.0
crypto 8e447d8cc585 # v0.10.0
mod 62c7e578f1a7
net f5464ddb689c
sync 93782cc822b6
sys 55b11dcdae81 # v0.9.0
term f6de4a13df88 # v0.9.0
text 2df65d769a9e
tools c6c983054920

@dmitshur dmitshur mentioned this issue Jun 23, 2023
Closed
@heschi heschi changed the title all: golang.org/x repos need to stay green all: user-facing golang.org/x repos need to stay green Jun 23, 2023
@cherrymui
Copy link
Member

Updated internal-branch.go1.21-vendor branches to the commits for latest merge into the main repo (as of
https://go.dev/cl/509099 )

arch	060bf14d30f8a6b2e19c8aab764c104725b1682f v0.4.0
crypto	2e82bdd1719d8f50d18bbb60acc52accc71330b1 v0.11.1-0.20230711161743-2e82bdd1719d
mod	baa5c2d058db25484c20d76985ba394e73176132 v0.12.0
net	57553cbff16307d5178b250ad301e7b466f9d969 v0.12.1-0.20230712162946-57553cbff163
sync	93782cc822b6b554cb7df40332fd010f0473cbc8 v0.3.0 // UNCHANGED
sys	a1a9c4b846b3a485ba94fede5b50579c7f432759 v0.10.0
term	edd9fb7f4aabf5aa4c7bca2146907778a2af0321 v0.10.0
text	e50348080f29449bcd6808c11400b3d45f08b09d v0.11.0
tool	1ca21856af7bffea38bd16dc62d9d31f4b6b5b86 v0.11.1-0.20230712164437-1ca21856af7b

@heschi
Copy link
Contributor

heschi commented Aug 4, 2023

Moving to 1.22.

@heschi heschi modified the milestones: Go1.21, Go1.22 Aug 4, 2023
BiiChris pushed a commit to BiiChris/crypto that referenced this issue Sep 15, 2023
@davecheney
ssh: fix flake in TestHostKeyCert
d8af72f 
Update golang/go#11811

The increased default concurrency in Go 1.5 showed up a test flake in
the TestHostKeyCert test. Under load, when the client provided incorrect
data, both sides would race to tear down the connection, which would often
lead to the server side, running in its own goroutine to see an unexpected
EOF or connection reset.

Fix this flake (and the incorrect use of t.Fatalf) by passing the error back
to the main goroutine for inspection. This also lets us ignore the expected
error in the unsuccessful path

Change-Id: I5a95c6d240479e9d537f34177e5ca8023b1b08e9
Reviewed-on: https://go-review.googlesource.com/12916
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
NeedsFix The path to resolution is known, but the work has not been done. recurring Issues that should never be closed, but moved to the next milestone once fixed in the current one. release-blocker
Projects
Release Status & Blockers (1.21)
Status: No status
Milestone
Go1.22
Development

No branches or pull requests