Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proposal: regexp: port RE2's CoalesceWalker to Go's regexp package #11855

Closed
junyer opened this issue Jul 24, 2015 · 5 comments
Closed

proposal: regexp: port RE2's CoalesceWalker to Go's regexp package #11855

junyer opened this issue Jul 24, 2015 · 5 comments

Comments

@junyer
Copy link
Contributor

@junyer junyer commented Jul 24, 2015

google/re2@b77e1a4 added an optimisation to RE2. I'm offering to port this to Go's regexp package for the sake of feature parity.

@ianlancetaylor
Copy link
Contributor

@ianlancetaylor ianlancetaylor commented Jul 24, 2015

CC @rsc

@robpike
Copy link
Contributor

@robpike robpike commented Jul 26, 2015

Go's regexp isn't trying to be at performance parity with RE2, which is overengineered. The issue of ambiguity is mostly an internal matter. Is all this code worthwhile for the core library? RE2 is available for wrapping if you need it.

@junyer
Copy link
Contributor Author

@junyer junyer commented Jul 27, 2015

Fair call. I had observed that Go already supports factoring out common prefixes of alternations as per https://github.com/golang/go/blob/master/src/regexp/syntax/parse.go#L394, so I figured that I would at least offer. :)

@rsc
Copy link
Contributor

@rsc rsc commented Aug 10, 2015

It's good to know it's there, but I think we can wait until a need arises. Thanks.

@adg, how does one decline a proposal?

@adg adg added the Proposal label Aug 10, 2015
@adg
Copy link
Contributor

@adg adg commented Aug 10, 2015

@rsc say "Thanks, but we'll decline for now." and close the issue. (like so :-))

@adg adg closed this Aug 10, 2015
@golang golang locked and limited conversation to collaborators Aug 9, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
6 participants
You can’t perform that action at this time.