Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
In encode.go, type encodeState has two methods, stringBytes and string, each of which return (int, error). In both cases, the only error that is returned from the methods is nil, and the int that is returned is never read:
type encodeState
stringBytes
string
nil
_, err := e.stringBytes(...)
e.string(...)
Return values are similarly ignored in encode_test.go:
encode_test.go
_, err := e.string(...)
I believe these methods can simply return nothing without any change in functionality.
The text was updated successfully, but these errors were encountered:
CL https://golang.org/cl/15836 mentions this issue.
Sorry, something went wrong.
0731471
No branches or pull requests
In encode.go,
type encodeState
has two methods,stringBytes
andstring
, each of which return (int, error). In both cases, the only error that is returned from the methods isnil
, and the int that is returned is never read:_, err := e.stringBytes(...)
on lines 449, 465e.string(...)
on lines 544, 546, 580, 615Return values are similarly ignored in
encode_test.go
:_, err := e.string(...)
on line 384_, err := e.stringBytes(...)
on line 390I believe these methods can simply return nothing without any change in functionality.
The text was updated successfully, but these errors were encountered: