Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

net/http: TestTransportCancelBeforeResponseHeaders is flaky #11894

Closed
bradfitz opened this issue Jul 27, 2015 · 2 comments

Comments

Projects
None yet
2 participants
@bradfitz
Copy link
Member

commented Jul 27, 2015

I'm going to disable this test for now, as it's flaky with:

--- FAIL: TestTransportCancelBeforeResponseHeaders (0.00s)
    transport_test.go:1592: RoundTrip error = io: read/write on closed pipe; want ExportErrRequestCanceled
FAIL

Fix and re-enable later.

@bradfitz bradfitz self-assigned this Jul 27, 2015

@bradfitz bradfitz added this to the Go1.6 milestone Jul 27, 2015

@gopherbot

This comment has been minimized.

Copy link

commented Jul 27, 2015

CL https://golang.org/cl/12731 mentions this issue.

bradfitz added a commit that referenced this issue Jul 28, 2015

net/http: disable new flaky TestTransportCancelBeforeResponseHeaders …
…test

I'll rewrite this later. It's apparently dependent on scheduling order.
The earlier fix in git rev 9d56c18 seems fine, though.

Update #11894

Change-Id: I7c150918af4be079c262a5f2933ef4639cc535ef
Reviewed-on: https://go-review.googlesource.com/12731
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Andrew Gerrand <adg@golang.org>
@gopherbot

This comment has been minimized.

Copy link

commented Jan 6, 2016

CL https://golang.org/cl/18287 mentions this issue.

@bradfitz bradfitz closed this in fb39401 Jan 6, 2016

@golang golang locked and limited conversation to collaborators Jan 7, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.