Skip to content

/go

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

encoding/json: UnmarshalJSON null behavior change broke real programs #11912

Closed
rsc opened this issue Jul 28, 2015 · 2 comments

Comments

Assignees

@rsc rsc

Labels
FrozenDueToAge
Projects
None yet
Milestone
  Go1.5
3 participants
@rsc @dspezia @gopherbot
@rsc
Copy link
Contributor

commented Jul 28, 2015

Reported by Dominik Honnef on golang-dev.
Hypothetical example: http://play.golang.org/p/t6e-FEbA5j
I've asked for a real one.

Regardless of that problem, it also seems wrong that we still
allocate the structure before deciding not to call UnmarshalJSON.
So I think this change is wrong either way, and we should
probably roll it back and think harder for Go 1.6, like we are
doing for encoding/xml's name space changes.

Will wait for Dominik's reply.

@rsc rsc self-assigned this Jul 28, 2015

@rsc rsc added this to the Go1.5 milestone Jul 28, 2015

@dspezia

This comment has been minimized.

Sign in to view
Copy link
Contributor

commented Jul 30, 2015

Another issue: #11937
@gopherbot

This comment has been minimized.

Sign in to view
Copy link

commented Jul 30, 2015

CL https://golang.org/cl/12893 mentions this issue.

@rsc rsc closed this in 80e6d63 Jul 30, 2015

@golang golang locked and limited conversation to collaborators Aug 5, 2016

@gopherbot gopherbot added the FrozenDueToAge label Aug 5, 2016

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.