Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gccgo, syscall: Regression in mksysinfo.sh causes libgo build to hang #11924

Closed
laboger opened this issue Jul 29, 2015 · 1 comment
Closed

gccgo, syscall: Regression in mksysinfo.sh causes libgo build to hang #11924

laboger opened this issue Jul 29, 2015 · 1 comment
Milestone

Comments

@laboger
Copy link
Contributor

@laboger laboger commented Jul 29, 2015

After a recent change to libgo/mksysinfo.sh to gccgo to add some of the ioctl constants from if_tun.h, it was discovered that the change could cause the ppc64le or ppc64 build to hang on some systems. The problem appears to be due to a missing space on some lines that were using grep; when the space is added to those lines the hang no longer occurs.

Here is an example:

-if ! grep '^const TUNGETVNETHDRSZ'${OUT} >/dev/null 2>&1; then
+if ! grep '^const TUNGETVNETHDRSZ' ${OUT} >/dev/null 2>&1; then

I have a fix for this. I'm not sure why it happens on some systems and not others, possibly due to different versions of grep.

@gopherbot
Copy link

@gopherbot gopherbot commented Jul 29, 2015

CL https://golang.org/cl/12835 mentions this issue.

@mikioh mikioh added this to the Gccgo milestone Jul 30, 2015
vries pushed a commit to vries/gcc that referenced this issue Jul 30, 2015
    
    In a recent change to mksysinfo.sh, a space was missing on
    some lines which caused the libgo build to hang on some
    systems.  This corrects that problem.
    
    Fixes golang/go#11924
    
    Reviewed-on: https://go-review.googlesource.com/12835


git-svn-id: svn+ssh://gcc.gnu.org/svn/gcc/trunk@226366 138bc75d-0d04-0410-961f-82ee72b054a4
pbeeler pushed a commit to SaberMod/GCC_SaberMod that referenced this issue Aug 4, 2015
    syscall:  Add ioctl consts from if_tun.h
    
    During the gccgo build define constants from
    some header files are processed by mksysinfo.sh and
    added to syscall.go.  In some cases the constants
    are based on macros which are not processed
    correctly by mksysinfo.sh.  This adds the support
    to generate the correct values for the TUN* constants
    from linux/if_tun.h.
    
    Fixes golang/go#11707
    
    Reviewed-on: https://go-review.googlesource.com/12491

    syscall:  Fix to libgo/mksysinfo.sh
    
    In a recent change to mksysinfo.sh, a space was missing on
    some lines which caused the libgo build to hang on some
    systems.  This corrects that problem.
    
    Fixes golang/go#11924
    
    Reviewed-on: https://go-review.googlesource.com/12835

    syscall:  RawSockaddr fix for ppc64, ppc64le
    
    The struct RawSockaddr contains a field Data which
    should be uint8 on ppc64 and ppc64le, but is declared
    as int8 in gccgo.  This change adds a two new files
    which contain the structure declaration for
    RawSockaddr, one with the correct types for for ppc64
    and ppc64le, and the other for non-ppc64 platforms.
    
    Fixes golang/go#11469
    
    Reviewed-on: https://go-review.googlesource.com/11946


git-svn-id: svn+ssh://gcc.gnu.org/svn/gcc/branches/gcc-5-branch@226595 138bc75d-0d04-0410-961f-82ee72b054a4
@golang golang locked and limited conversation to collaborators Aug 5, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.