Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go/types: refers to go/constant as exact #11949

Closed
dvyukov opened this issue Jul 30, 2015 · 2 comments
Closed

go/types: refers to go/constant as exact #11949

dvyukov opened this issue Jul 30, 2015 · 2 comments
Assignees
Milestone

Comments

@dvyukov
Copy link
Member

@dvyukov dvyukov commented Jul 30, 2015

go/types docs:
http://tip.golang.org/pkg/go/types
periodically refer to a package exact. For example:

Constant folding computes the exact constant value (exact.Value) for every expression

and:

type TypeAndValue struct {
    Type  Type
    Value exact.Value
    // contains filtered or unexported fields
}

This is very confusing. There is no package exact.
I understand this was introduced during refactoring, but the cost of confused users is higher than the cost of sed invocation.

@griesemer griesemer added this to the Go1.6 milestone Jul 30, 2015
@griesemer
Copy link
Contributor

@griesemer griesemer commented Jul 30, 2015

Since we're late in the release cycle I'll address the documentation (comment) issue for now.

Loading

griesemer added a commit that referenced this issue Jul 30, 2015
For #11949.

Change-Id: I4329604a24efc7f40cf5bf52fb3c9e30916b3cc2
Reviewed-on: https://go-review.googlesource.com/12931
Reviewed-by: Alan Donovan <adonovan@google.com>
@gopherbot
Copy link

@gopherbot gopherbot commented Aug 3, 2015

CL https://golang.org/cl/13051 mentions this issue.

Loading

@robpike robpike closed this in ecead89 Aug 4, 2015
@mikioh mikioh added this to the Go1.5 milestone Aug 4, 2015
@mikioh mikioh removed this from the Go1.6 milestone Aug 4, 2015
@golang golang locked and limited conversation to collaborators Aug 5, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants