Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/crypto/ocsp: ParseResponse pitfalls #11984

Open
takeyourhatoff opened this issue Aug 2, 2015 · 2 comments
Open

x/crypto/ocsp: ParseResponse pitfalls #11984

takeyourhatoff opened this issue Aug 2, 2015 · 2 comments
Assignees
Milestone

Comments

@takeyourhatoff
Copy link

@takeyourhatoff takeyourhatoff commented Aug 2, 2015

There are two pitfalls in the ParseResponse method of "x/cryto/ocsp". The first being that if you forget to pass in an issuer then the response will be parsed but signature verification will not be performed. The second is that some people might assume that when err != nil, Response.Status == Good. I would suggest an additional idiot proof method VerifyResponse which might look a little like this:

https://play.golang.org/p/eTkpQi_gDk

@adg adg changed the title Pitfalls in "x/crypto/ocsp".ParseResponse x/crypto/ocsp: ParseResponse pitfalls Aug 3, 2015
@adg
Copy link
Contributor

@adg adg commented Aug 3, 2015

cc @agl

@agl agl self-assigned this Aug 3, 2015
@rsc rsc added this to the Unreleased milestone Aug 6, 2015
@odeke-em
Copy link
Member

@odeke-em odeke-em commented Feb 18, 2017

Hello there @takeyourhatoff, still interested in working on this? Perhaps a CL might re-ignite the conversation and it can then be reviewed. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
5 participants
You can’t perform that action at this time.