Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/crypto/ocsp: ParseResponse pitfalls #11984

takeyourhatoff opened this issue Aug 2, 2015 · 2 comments

x/crypto/ocsp: ParseResponse pitfalls #11984

takeyourhatoff opened this issue Aug 2, 2015 · 2 comments


Copy link

There are two pitfalls in the ParseResponse method of "x/cryto/ocsp". The first being that if you forget to pass in an issuer then the response will be parsed but signature verification will not be performed. The second is that some people might assume that when err != nil, Response.Status == Good. I would suggest an additional idiot proof method VerifyResponse which might look a little like this:

@adg adg changed the title Pitfalls in "x/crypto/ocsp".ParseResponse x/crypto/ocsp: ParseResponse pitfalls Aug 3, 2015
Copy link

adg commented Aug 3, 2015

cc @agl

@agl agl self-assigned this Aug 3, 2015
@rsc rsc added this to the Unreleased milestone Aug 6, 2015
Copy link

Hello there @takeyourhatoff, still interested in working on this? Perhaps a CL might re-ignite the conversation and it can then be reviewed. Thanks!

@rsc rsc unassigned agl Jun 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

No branches or pull requests

5 participants