Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

net/http: race in TestTransportAndServerSharedBodyRace #11985

Closed
mikioh opened this issue Aug 3, 2015 · 4 comments

Comments

Projects
None yet
3 participants
@mikioh
Copy link
Contributor

commented Aug 3, 2015

See http://build.golang.org/log/9493424c051981be4ce433ab4997c99c79ebe783.

==================
WARNING: DATA RACE
Write by goroutine 100:
  net/http.(*body).Close()
      C:/workdir/go/src/net/http/transfer.go:788 +0x12e
  net/http.(*Request).closeBody()
      C:/workdir/go/src/net/http/request.go:1006 +0x7e
  net/http.(*persistConn).writeLoop()
      C:/workdir/go/src/net/http/transport.go:1022 +0x3bb

Previous read by goroutine 98:
  net/http.(*chunkWriter).writeHeader()
      C:/workdir/go/src/net/http/server.go:884 +0xfdc
  net/http.(*chunkWriter).Write()
      C:/workdir/go/src/net/http/server.go:261 +0xbf
  bufio.(*Writer).flush()
      C:/workdir/go/src/bufio/bufio.go:562 +0x1ae
  bufio.(*Writer).Flush()
      C:/workdir/go/src/bufio/bufio.go:551 +0x41
  net/http.(*response).finishRequest()
      C:/workdir/go/src/net/http/server.go:1151 +0xa7
  net/http.(*conn).serve()
      C:/workdir/go/src/net/http/server.go:1363 +0x11c2

Goroutine 100 (running) created at:
  net/http.(*Transport).dialConn()
      C:/workdir/go/src/net/http/transport.go:693 +0x119a
  net/http.(*Transport).getConn.func4()
      C:/workdir/go/src/net/http/transport.go:549 +0x7a

Goroutine 98 (running) created at:
  net/http.(*Server).Serve()
      C:/workdir/go/src/net/http/server.go:1908 +0x46b
==================
PASS
Found 1 data race(s)
FAIL    net/http    12.776s

@mikioh mikioh added this to the Go1.5Maybe milestone Aug 3, 2015

@mikioh

This comment has been minimized.

Copy link
Contributor Author

commented Aug 3, 2015

/CC @bradfitz

@bradfitz

This comment has been minimized.

Copy link
Member

commented Aug 3, 2015

Looking. Mailed golang-dev before I saw this.

@bradfitz

This comment has been minimized.

Copy link
Member

commented Aug 3, 2015

@gopherbot

This comment has been minimized.

Copy link

commented Aug 3, 2015

CL https://golang.org/cl/12909 mentions this issue.

@bradfitz bradfitz closed this in 7aa4e29 Aug 3, 2015

@mikioh mikioh modified the milestones: Go1.5, Go1.5Maybe Aug 3, 2015

@golang golang locked and limited conversation to collaborators Aug 5, 2016

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.