New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

runtime: reenable TestCgoCallbackGC on dragonfly #11990

Open
mikioh opened this Issue Aug 3, 2015 · 6 comments

Comments

Projects
None yet
4 participants
@mikioh
Contributor

mikioh commented Aug 3, 2015

For example,

go test -v -run=TestCgoCallbackGC
=== RUN   TestCgoCallbackGC
--- PASS: TestCgoCallbackGC (175.54s)
PASS
ok      runtime 175.548s

Not sure the reason but it perhaps harms the dragonfly buildbot.

@mikioh mikioh added the OS-Dragonfly label Aug 3, 2015

@mikioh mikioh added this to the Unplanned milestone Aug 3, 2015

@mikioh

This comment has been minimized.

Contributor

mikioh commented Aug 3, 2015

% uname -a
DragonFly 4.2-RELEASE DragonFly v4.2.3.5.g519f0-RELEASE /usr/obj/usr/src/sys/X86_64_GENERIC x86_64

@mikioh mikioh modified the milestones: Go1.5, Unplanned Aug 3, 2015

@gopherbot

This comment has been minimized.

gopherbot commented Aug 3, 2015

CL https://golang.org/cl/13050 mentions this issue.

mikioh pushed a commit that referenced this issue Aug 3, 2015

Mikio Hara
runtime: skip TestCgoCallbackGC on dragonfly
Updates #11990.

Change-Id: I6c58923a1b5a3805acfb6e333e3c9e87f4edf4ba
Reviewed-on: https://go-review.googlesource.com/13050
Reviewed-by: Ian Lance Taylor <iant@golang.org>

@mikioh mikioh modified the milestones: Go1.6, Go1.5 Aug 3, 2015

@rsc

This comment has been minimized.

Contributor

rsc commented Nov 23, 2015

Work on Dragonfly is unplanned, since it is not a first-class port.

@rsc rsc modified the milestones: Unplanned, Go1.6 Nov 23, 2015

@mikioh mikioh modified the milestones: Go1.8, Unplanned May 19, 2016

@mikioh

This comment has been minimized.

Contributor

mikioh commented May 20, 2016

Looks like DragonFly BSD 4.4.x kernels have no issues. Let's re-enable TestCgoCallbackGC in Go 1.8.

@quentinmit quentinmit added the NeedsFix label Sep 29, 2016

@quentinmit quentinmit changed the title from runtime: TestCgoCallbackGC takes a bit long time (175.54s) on dragonfly to runtime: reenable TestCgoCallbackGC on dragonfly Sep 29, 2016

@quentinmit quentinmit self-assigned this Sep 29, 2016

@mikioh

This comment has been minimized.

Contributor

mikioh commented Oct 1, 2016

Just tried TestCgoCallbackGC w/ tip (go version devel +09fb795) on DragonFly v4.6.0.20.ged336-RELEASE.

go test -v -run=TestCgoCallbackGC -count=10
=== RUN   TestCgoCallbackGC
--- PASS: TestCgoCallbackGC (11.94s)
=== RUN   TestCgoCallbackGC
--- PASS: TestCgoCallbackGC (13.78s)
=== RUN   TestCgoCallbackGC
--- PASS: TestCgoCallbackGC (17.62s)
=== RUN   TestCgoCallbackGC
--- PASS: TestCgoCallbackGC (9.06s)
=== RUN   TestCgoCallbackGC
--- PASS: TestCgoCallbackGC (39.77s)
=== RUN   TestCgoCallbackGC
--- PASS: TestCgoCallbackGC (4.68s)
=== RUN   TestCgoCallbackGC
--- PASS: TestCgoCallbackGC (39.87s)
=== RUN   TestCgoCallbackGC
--- PASS: TestCgoCallbackGC (32.53s)
=== RUN   TestCgoCallbackGC
--- PASS: TestCgoCallbackGC (18.07s)
=== RUN   TestCgoCallbackGC
--- PASS: TestCgoCallbackGC (22.77s)
PASS
ok      runtime 210.103s

Perhaps it might be better to mark this issue with unplanned.

@quentinmit

This comment has been minimized.

Contributor

quentinmit commented Oct 14, 2016

Okay, it sounds like you think 10-30s is too slow. -> Unplanned.

@quentinmit quentinmit removed their assignment Oct 14, 2016

@quentinmit quentinmit modified the milestones: Unplanned, Go1.8 Oct 14, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment