Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/dist: useless -s flag #12002

Closed
mdempsky opened this issue Aug 3, 2015 · 2 comments
Closed

cmd/dist: useless -s flag #12002

mdempsky opened this issue Aug 3, 2015 · 2 comments
Assignees
Milestone

Comments

@mdempsky
Copy link
Member

@mdempsky mdempsky commented Aug 3, 2015

Dist's "bootstrap" and "install" subcommands both support a -s flag to "build static binaries", but sflag doesn't appear to be used anywhere. Seems like either: 1) the flag should be made to work, 2) the flag should be removed, or 3) the flag should be documented that it doesn't actually do anything.

@ianlancetaylor ianlancetaylor added this to the Go1.6 milestone Aug 3, 2015
@rsc
Copy link
Contributor

@rsc rsc commented Nov 5, 2015

Should be removed. It was for compiling C code.

@rsc rsc modified the milestones: Unplanned, Go1.6 Nov 5, 2015
@mdempsky mdempsky self-assigned this Nov 5, 2015
@gopherbot
Copy link

@gopherbot gopherbot commented Nov 5, 2015

CL https://golang.org/cl/16666 mentions this issue.

@mdempsky mdempsky closed this in 7bb2a7d Nov 5, 2015
bradfitz added a commit that referenced this issue Dec 17, 2015
(Found while debugging release problems with go1.6beta1)

Updates #12002

Change-Id: Iec197a754205e7fd28be154f27f17f3315886364
Reviewed-on: https://go-review.googlesource.com/18011
Reviewed-by: Chris Broadfoot <cbro@golang.org>
@golang golang locked and limited conversation to collaborators Nov 4, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.