Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools/refactor/rename: fails if cgo build would fail #12044

Open
jmhodges opened this issue Aug 6, 2015 · 0 comments

Comments

@jmhodges
Copy link
Contributor

commented Aug 6, 2015

I have some CGO_CFLAGS and CGO_LDFLAGS settings I have to use to build a project I have, but gorename inside emacs doesn't have access to those.

gorename fails on this project (and ones that depend on it) because it cannot find the C headers. However, gorename doesn't support cgo and so doesn't really need to inspect those headers.

It would be nice for rename to not care about cgo so that we didn't have to mess with cgo's env variables for each project (esp since some might, in rare cases, have conflicting needs).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.