Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools/refactor/rename: Cannot rename implementation if there is no interface value constructed #12049

Closed
isaiah opened this issue Aug 6, 2015 · 1 comment
Assignees
Milestone

Comments

@isaiah
Copy link

@isaiah isaiah commented Aug 6, 2015

FYI, I am not sure if this is desired behaviour, the issue can be reproduced by the following change to the tests.

diff --git a/refactor/rename/rename_test.go b/refactor/rename/rename_test.go
index 1d282a1..c770693 100644
--- a/refactor/rename/rename_test.go
+++ b/refactor/rename/rename_test.go
@@ -736,8 +736,6 @@ func (B) g()
 type C int
 func (C) f()
 func (C) g()
-var _, _ I = A(0), B(0)
-var _, _ J = B(0), C(0)
 `,
                                },
                        }),
@@ -765,9 +763,6 @@ type C int

 func (C) F()
 func (C) g()
-
-var _, _ I = A(0), B(0)
-var _, _ J = B(0), C(0)
 `,
                        },
                },
@@ -796,9 +791,6 @@ type C int

 func (C) F()
 func (C) g()
-
-var _, _ I = A(0), B(0)
-var _, _ J = B(0), C(0)
 `,
                        },
                },
@@ -827,9 +819,6 @@ type C int

 func (C) f()
 func (C) G()
-
-var _, _ I = A(0), B(0)
-var _, _ J = B(0), C(0)
 `,
                        },
                },
@isaiah
Copy link
Author

@isaiah isaiah commented Aug 6, 2015

@josharian said it's by design, closing.

@isaiah isaiah closed this Aug 6, 2015
@golang golang locked and limited conversation to collaborators Aug 5, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.