Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

net/rpc: lose cached Request on EOF #12103

Open
powerman opened this issue Aug 10, 2015 · 1 comment
Open

net/rpc: lose cached Request on EOF #12103

powerman opened this issue Aug 10, 2015 · 1 comment
Milestone

Comments

@powerman
Copy link

@powerman powerman commented Aug 10, 2015

It looks like a (performance) bug at https://github.com/golang/go/blob/master/src/net/rpc/server.go#L578 - I think before req = nil this should be added:

server.freeRequest(req)
@ianlancetaylor ianlancetaylor added this to the Go1.6 milestone Aug 11, 2015
@rsc rsc modified the milestones: Unplanned, Go1.6 Dec 3, 2015
@meirf

This comment has been minimized.

Copy link
Contributor

@meirf meirf commented May 8, 2018

The url posted by the OP is relative to master which changes over time and currently points to the wrong line. Here is the url relative to the latest commit when this issue was created:

req = nil

(Sorry I don't have more value to add here right now in the form of actual code; will need to spend more time absorbing this package.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.