Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/build: linux image is missing openal #12183

Closed
crawshaw opened this issue Aug 18, 2015 · 6 comments
Closed

x/build: linux image is missing openal #12183

crawshaw opened this issue Aug 18, 2015 · 6 comments
Assignees
Milestone

Comments

@crawshaw
Copy link
Contributor

@crawshaw crawshaw commented Aug 18, 2015

The linux/amd64 builder fails testing x/mobile with

# golang.org/x/mobile/exp/audio/al
../../gopath/src/golang.org/x/mobile/exp/audio/al/al_notandroid.go:22:19: fatal error: AL/al.h: No such file or directory

http://build.golang.org/log/4bbb065ef9b14874e7ed52fe2034e02eff32cc53

It may be that the test should be resilient to the library being missing so that users can run go test golang.org/x/mobile/..., but we should also be testing this code on the builders, which means the linux image needs a copy of OpenAL installed.

/cc @rakyll @adg

@hyangah
Copy link
Contributor

@hyangah hyangah commented Aug 18, 2015

I added openal to the the list-x86-std Dockerfile but didn't perform the process to build a new image out of it https://go-review.googlesource.com/12891

@bradfitz
Copy link
Contributor

@bradfitz bradfitz commented Aug 19, 2015

In the future, don't submit Dockerfile changes until they've been tested & deployed on the staging instance.
/cc @adg

@hyangah
Copy link
Contributor

@hyangah hyangah commented Aug 19, 2015

I see. Sorry for submitting it without properly testing it.
Is there a doc that I can reference for testing/staging?

@rakyll
Copy link
Member

@rakyll rakyll commented Sep 27, 2015

Should we close this issue now?

@bradfitz
Copy link
Contributor

@bradfitz bradfitz commented Oct 4, 2015

Not yet.

@evandbrown just about has Kubernetes builders working, and it's using the new Dockerfile image with these libraries, so let's wait to close this until that works.

@rsc rsc added this to the Unreleased milestone Oct 23, 2015
@gopherbot gopherbot added the Builders label Mar 21, 2017
@bradfitz
Copy link
Contributor

@bradfitz bradfitz commented Mar 8, 2019

@bradfitz bradfitz closed this Mar 8, 2019
@golang golang locked and limited conversation to collaborators Mar 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
6 participants
You can’t perform that action at this time.