Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

net: windows and plan 9 return unrooted DNS names #12193

Closed
rsc opened this issue Aug 19, 2015 · 3 comments

Comments

Projects
None yet
2 participants
@rsc
Copy link
Contributor

commented Aug 19, 2015

As part of fixing #12189 I wrote TestLookupDots that checks for rooted DNS names being returned from the lookup routines. On the builders, all the Unix systems agree (due to the fix in CL 13697) but Windows and Plan 9 do not:

https://storage.googleapis.com/go-build-log/22995b82/windows-amd64-gce_1f5c31d1.log

--- FAIL: TestLookupDots (0.02s)
    lookup_test.go:420: LookupAddr(8.8.8.8) = [google-public-dns-a.google.com], want names ending in .google.com. with trailing dot (mode=go)
    lookup_test.go:460: LookupSRV(xmpp-server, tcp, google.com) returned cname=google.com, want name ending in .google.com. with trailing dot (mode=go)
    lookup_test.go:464: LookupSRV(xmpp-server, tcp, google.com) returned addrs=[xmpp-server.l.google.com:5269:5:0 alt2.xmpp-server.l.google.com:5269:20:0 alt1.xmpp-server.l.google.com:5269:20:0 alt4.xmpp-server.l.google.com:5269:20:0 alt3.xmpp-server.l.google.com:5269:20:0], want names ending in .google.com. with trailing dot (mode=go)
FAIL
FAIL    net 7.246s

https://storage.googleapis.com/go-build-log/22995b82/plan9-386_6f2fc89c.log

--- FAIL: TestLookupDots (0.03s)
    lookup_test.go:420: LookupAddr(8.8.8.8) = [google-public-dns-a.google.com], want names ending in .google.com. with trailing dot (mode=go)
    lookup_test.go:437: LookupMX(google.com) = [aspmx.l.google.com:10 alt1.aspmx.l.google.com:20 alt2.aspmx.l.google.com:30 alt3.aspmx.l.google.com:40 alt4.aspmx.l.google.com:50], want names ending in .google.com. with trailing dot (mode=go)
    lookup_test.go:449: LookupNS(google.com) = [ns2.google.com ns4.google.com ns1.google.com ns3.google.com], want names ending in .google.com. with trailing dot (mode=go)
    lookup_test.go:460: LookupSRV(xmpp-server, tcp, google.com) returned cname=_xmpp-server._tcp.google.com, want name ending in .google.com. with trailing dot (mode=go)
    lookup_test.go:464: LookupSRV(xmpp-server, tcp, google.com) returned addrs=[alt1.xmpp-server.l.google.com:5269:0:20 alt3.xmpp-server.l.google.com:5269:0:20 alt4.xmpp-server.l.google.com:5269:0:20 alt2.xmpp-server.l.google.com:5269:0:20 xmpp-server.l.google.com:5269:0:5], want names ending in .google.com. with trailing dot (mode=go)
FAIL

I believe they should match the others but since they have done this for all earlier Go releases too - that is, this behavior on Plan 9 and Windows is the same as it was on Go 1.4 - I am not going to change it for Go 1.5. We can fix this discrepancy deliberately in the regular Go 1.6 cycle.

@rsc rsc added this to the Go1.6Early milestone Aug 19, 2015

@gopherbot

This comment has been minimized.

Copy link

commented Aug 26, 2015

CL https://golang.org/cl/13887 mentions this issue.

@gopherbot

This comment has been minimized.

Copy link

commented Oct 8, 2015

CL https://golang.org/cl/15581 mentions this issue.

alexbrainman added a commit that referenced this issue Dec 3, 2015

net: return rooted DNS names on windows
This CL also changes windows LookupSRV to return
_xmpp-server._tcp.google.com. as cname instead of google.com
similar to linux. Otherwise TestLookupDots still fails.

Updates #12193 (with plan9 still to do)

Change-Id: Id225e15bee95037cdb4226803506cce690c5d341
Reviewed-on: https://go-review.googlesource.com/13887
Run-TryBot: Alex Brainman <alex.brainman@gmail.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>

0intro added a commit that referenced this issue Dec 4, 2015

net: return rooted DNS names on Plan 9
This change returns rooted DNS names on Plan 9,
for consistency with other operating systems.

Updates #12193.

Change-Id: If983920c5b9a8f67d4ccb51bb295fac8dfb87e88
Reviewed-on: https://go-review.googlesource.com/15581
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Run-TryBot: David du Colombier <0intro@gmail.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Mikio Hara <mikioh.mikioh@gmail.com>
@gopherbot

This comment has been minimized.

Copy link

commented Dec 4, 2015

CL https://golang.org/cl/17411 mentions this issue.

@mikioh mikioh closed this in d2ca451 Dec 5, 2015

@golang golang locked and limited conversation to collaborators Dec 14, 2016

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.