Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
net: windows and plan 9 return unrooted DNS names #12193
As part of fixing #12189 I wrote TestLookupDots that checks for rooted DNS names being returned from the lookup routines. On the builders, all the Unix systems agree (due to the fix in CL 13697) but Windows and Plan 9 do not:
I believe they should match the others but since they have done this for all earlier Go releases too - that is, this behavior on Plan 9 and Windows is the same as it was on Go 1.4 - I am not going to change it for Go 1.5. We can fix this discrepancy deliberately in the regular Go 1.6 cycle.
This CL also changes windows LookupSRV to return _xmpp-server._tcp.google.com. as cname instead of google.com similar to linux. Otherwise TestLookupDots still fails. Updates #12193 (with plan9 still to do) Change-Id: Id225e15bee95037cdb4226803506cce690c5d341 Reviewed-on: https://go-review.googlesource.com/13887 Run-TryBot: Alex Brainman <firstname.lastname@example.org> TryBot-Result: Gobot Gobot <email@example.com> Reviewed-by: Brad Fitzpatrick <firstname.lastname@example.org>
This change returns rooted DNS names on Plan 9, for consistency with other operating systems. Updates #12193. Change-Id: If983920c5b9a8f67d4ccb51bb295fac8dfb87e88 Reviewed-on: https://go-review.googlesource.com/15581 Reviewed-by: Brad Fitzpatrick <email@example.com> Run-TryBot: David du Colombier <firstname.lastname@example.org> TryBot-Result: Gobot Gobot <email@example.com> Reviewed-by: Mikio Hara <firstname.lastname@example.org>