Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/build/cmd/release: Cannot upgrade to go 1.5 directly through MSI package #12213

Closed
linquize opened this issue Aug 20, 2015 · 27 comments
Closed

x/build/cmd/release: Cannot upgrade to go 1.5 directly through MSI package #12213

linquize opened this issue Aug 20, 2015 · 27 comments
Milestone

Comments

@linquize
Copy link

@linquize linquize commented Aug 20, 2015

I installed go 1.4.2 first.
Then I install go1.5.windows-amd64.msi package on Win7 x64.

It shows an error message:

Another version of this product is already installed.
Installation of this version cannot continue.
To configure or remove the existing version of this product,
use Add/Remove Programs on the Control Panel.

I expect it automatically upgrades previous version, but it does not.

@ianlancetaylor ianlancetaylor changed the title Cannot upgrade to go 1.5 directly through MSI package release: Cannot upgrade to go 1.5 directly through MSI package Aug 20, 2015
@ianlancetaylor ianlancetaylor added this to the Go1.5.1 milestone Aug 20, 2015
@adg adg changed the title release: Cannot upgrade to go 1.5 directly through MSI package x/build/cmd/release: Cannot upgrade to go 1.5 directly through MSI package Aug 20, 2015
@adg adg modified the milestones: Unplanned, Go1.5.1 Aug 20, 2015
@adg adg added the help wanted label Aug 20, 2015
@adg
Copy link
Contributor

@adg adg commented Aug 20, 2015

If someone can make this work, please do.

@adg adg removed their assignment Aug 20, 2015
@linquize
Copy link
Author

@linquize linquize commented Aug 20, 2015

Add upgrade attributes in wxs source

<Product ...>
...
<Upgrade ...>
  <UpgradeVersion ... />
</Upgrade>
</Product>
@adg
Copy link
Contributor

@adg adg commented Aug 20, 2015

@linquize want to implement it? I have no idea what I'm doing with the wxs stuff.

@linquize
Copy link
Author

@linquize linquize commented Aug 20, 2015

May be try to study from other projects
I remember the following project can upgrade from old version

https://github.com/jgm/pandoc/blob/master/windows/pandoc.wxs

@tylrmac
Copy link

@tylrmac tylrmac commented Aug 20, 2015

I can try to tackle this. (I've been looking for something to work on and this doesn't seem too hard)

@adg
Copy link
Contributor

@adg adg commented Aug 20, 2015

@tylrmac please do! let me know if you need help.

@tylrmac
Copy link

@tylrmac tylrmac commented Aug 20, 2015

@adg any tips for getting a Windows machine/VM set up for building a release build? I've never done a release build for Windows before. Already have my changes I'd like to test.

@alexbrainman
Copy link
Member

@alexbrainman alexbrainman commented Aug 20, 2015

@tylrmac

See this from #11740 (comment)

you could just run releaselet.go from a directory that contains a go directory containing a compiled Go tree. (and stub out the stuff in releaselet.go that tries to do the godoc/tour stuff)

You will need a windows computer with all bits installed.

golang.org/x/build/env/windows/README describes the way Go builders are configured. You would only need appropriate bits of software installed - you can use "winstrap" program as described in README.

Alex

@tylrmac
Copy link

@tylrmac tylrmac commented Aug 21, 2015

@alexbrainman Thanks! Have everything set up correctly now. Now to actually fix the problem...

@tylrmac
Copy link

@tylrmac tylrmac commented Aug 22, 2015

I have it working but the solution by default removes the old version before installing a newer version. Is that desired behavior?

It's possible to prompt the user that the installer will remove the old install but I want to double check before I get it ready for code review.

@alexbrainman
Copy link
Member

@alexbrainman alexbrainman commented Aug 22, 2015

@tylrmac I don't know what is the right choice here. I will let @adg decide.

Alex

@adg
Copy link
Contributor

@adg adg commented Aug 22, 2015

@tylrmac It would be great to prompt the user before deleting anything.

@tylrmac
Copy link

@tylrmac tylrmac commented Aug 27, 2015

I have this mostly working. Having a baby in a few days so will have to put off testing until after then.

@adg
Copy link
Contributor

@adg adg commented Aug 28, 2015

Thanks for your efforts!

On 28 August 2015 at 07:03, Tyler McEntee notifications@github.com wrote:

I have this mostly working. Having a baby in a few days so will have to
put off testing until after then.


Reply to this email directly or view it on GitHub
#12213 (comment).

@linquize
Copy link
Author

@linquize linquize commented Sep 11, 2015

ping

@tylrmac
Copy link

@tylrmac tylrmac commented Sep 11, 2015

Sorry @linquize, I have a fix but won't be able to do much with it until next week. Currently in the hospital awaiting the birth of our first child.

@oec
Copy link

@oec oec commented Oct 4, 2015

@tylrmac, if you sent me what you have so far, I can pick up from there. I have some experience with wxs from current projects... BTW, all the best for you and your familiy, hope all went well!

@gopherbot
Copy link

@gopherbot gopherbot commented Dec 21, 2015

CL https://golang.org/cl/18071 mentions this issue.

@linquize
Copy link
Author

@linquize linquize commented Dec 24, 2015

Will it be included in 1.5.3?

@alexbrainman
Copy link
Member

@alexbrainman alexbrainman commented Dec 24, 2015

Will it be included in 1.5.3?

I don't see why it wouldn't, but I don't know for sure. @adg builds msi files.

Alex

@ianlancetaylor
Copy link
Contributor

@ianlancetaylor ianlancetaylor commented Dec 24, 2015

I added the 1.5.3 milestone so that can be considered for 1.5.3 (if there is a 1.5.3). I don't know whether this is appropriate or not.

@linquize
Copy link
Author

@linquize linquize commented Jan 14, 2016

In golang website,
"If you are upgrading from an older version of Go you must first remove the existing version. "
This statement is no longer valid since 1.5.3 (Windows)

@bradfitz bradfitz modified the milestones: Go1.5.4, Go1.5.3 Jan 14, 2016
@alexbrainman
Copy link
Member

@alexbrainman alexbrainman commented Jan 14, 2016

This statement is no longer valid since 1.5.3 (Windows)

I think you're correct. I think we should change website text. Except I don't know where the source code is.

Alex

@linquize
Copy link
Author

@linquize linquize commented Jan 14, 2016

@tylrmac updated Windows installer package (msi) in 1.5.3. The website text shiuld reflect this change.

@voutasaurus
Copy link

@voutasaurus voutasaurus commented Feb 28, 2016

Great work @tylrmac !

@adg it would be great to tell people about this! :) (the website still says "If you are upgrading from an older version of Go you must first remove the existing version.")

@adg
Copy link
Contributor

@adg adg commented Mar 2, 2016

I would rather keep the text as-is, as it applies generally to all kinds of Go installation.

Further, encouraging people to uninstall before installing a new version will lead to fewer support queries in the long term.

@golang golang locked and limited conversation to collaborators Mar 13, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
9 participants
You can’t perform that action at this time.