Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
net: LookupPort("tcp", "123") no longer returns 123 #12263
This broke because the cgo-based lookup did accept "123" but the Go-based lookup does not. This means the behavior was at best inconsistent before, but it does make sense that you should be able to look up tcp/80 in addition to tcp/http.
If we have a more serious problem for a 1.5.1 this would be a candidate for an add-on.
This worked in Go 1.4 but was lost in the "pure Go" lookup routines substituted late in the Go 1.5 cycle. Fixes #12263. Change-Id: I77ec9d97cd8e67ace99d6ac965e5bc16c151ba83 Reviewed-on: https://go-review.googlesource.com/13915 Reviewed-by: Brad Fitzpatrick <email@example.com> Reviewed-on: https://go-review.googlesource.com/14243 Reviewed-by: Ian Lance Taylor <firstname.lastname@example.org>