Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/go: return an error for unsupported GOOS/GOARCH pair #12272

Closed
bradfitz opened this issue Aug 22, 2015 · 11 comments

Comments

@bradfitz
Copy link
Member

commented Aug 22, 2015

This bug is about cmd/go returning a useful error message when an invalid GOOS/GOARCH pair is used.

See confusion in #11908.

Related request in #12270 (if we fix this bug, we should probably fix both, using the same source of truth)

@minux

This comment has been minimized.

Copy link
Member

commented Aug 23, 2015

@rakyll

This comment has been minimized.

Copy link
Member

commented Oct 13, 2015

How about we make cmd/go print "perhaps unsupported platform?"

It won't help the users if the error message is uncertain, they will end up in the issue tracker or the mailing list to ask about the case.

Maintaining a single source of truth for the supported combinations are rather easy and explicit.

@minux

This comment has been minimized.

Copy link
Member

commented Oct 13, 2015

@rsc rsc added this to the Go1.6 milestone Oct 23, 2015
@rsc

This comment has been minimized.

Copy link
Contributor

commented Jan 14, 2016

Not critical for Go 1.6.

@gopherbot

This comment has been minimized.

Copy link

commented May 6, 2016

CL https://golang.org/cl/22838 mentions this issue.

@gopherbot gopherbot closed this in b90cb3f May 6, 2016
@a13xb

This comment has been minimized.

Copy link

commented Jul 12, 2016

Funny enough, we relied on the old behaviour.

We use go tool to build for Linux/MIPS target using gccgo (which does support MIPS), and works fine with 1.6, but now it's blocked by this check.

@quentinmit

This comment has been minimized.

Copy link
Contributor

commented Jul 12, 2016

Okay. I'll reopen the issue to take another look. @bradfitz Is this WAI or do we need to change or revert the check?

@quentinmit quentinmit reopened this Jul 12, 2016
@ianlancetaylor

This comment has been minimized.

Copy link
Contributor

commented Jul 12, 2016

Yes, I think we do need to fix this. We should not issue the error for -compiler=gccgo.

@bradfitz

This comment has been minimized.

Copy link
Member Author

commented Jul 12, 2016

On it.

@gopherbot

This comment has been minimized.

Copy link

commented Jul 12, 2016

CL https://golang.org/cl/24864 mentions this issue.

@gopherbot gopherbot closed this in a1110c3 Jul 12, 2016
@a13xb

This comment has been minimized.

Copy link

commented Jul 13, 2016

Incredible turnaround time on this one, thanks!

@golang golang locked and limited conversation to collaborators Jul 13, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
8 participants
You can’t perform that action at this time.