Skip to content

/go

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

encoding/json: Inconsistent spelling of unmarshaling/unmarshalling. #12431

Closed
dmitshur opened this issue Sep 1, 2015 · 3 comments

Comments

Assignees
No one assigned
Labels
FrozenDueToAge
Projects
None yet
Milestone
No milestone
3 participants
@dmitshur @gopherbot @bradfitz
@dmitshur
Copy link
Member

commented Sep 1, 2015

On lastest master commit, in encoding/json/decode.go file, there are two variations of spelling of the same word:

var spellingOccurrences = map[string]int{
    "unmarshaling":  2,
    "unmarshalling": 1,
}

It can be made better by having a consistent spelling, making it easier to find out which is the canonical spelling.

Edit: Including test files and "marshaling"/"marshalling", the count goes to 8 and 3, respectively.
@gopherbot

This comment has been minimized.

Sign in to view
Copy link

commented Sep 1, 2015

CL https://golang.org/cl/14150 mentions this issue.

@adg adg closed this in 143f3fd Sep 23, 2015

@golang golang locked and limited conversation to collaborators Sep 23, 2016

@gopherbot gopherbot added the FrozenDueToAge label Sep 23, 2016

@gopherbot

This comment has been minimized.

Sign in to view
Copy link

commented Nov 10, 2016

CL https://golang.org/cl/33017 mentions this issue.
@bradfitz

This comment has been minimized.

Sign in to view
Copy link
Member

commented Apr 16, 2019

More in https://go-review.googlesource.com/c/go/+/172457
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.