Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
GitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
x/tools/refactor/rename: scans entire workspace when renaming internal symbol #12439
When renaming a symbol in an internal package, gorename finds and reports buggy packages outside the internal tree:
Scanning the entire workspace seems unnecessary in this case, since symbols in internal packages cannot be imported outside the internal tree.
Because of Go's embedding mechanism, renaming symbols within internal packages can have effects that are visible to packages outside the "internal" subtree. So, this counterintuitive scan is required.
The oracle does need to be made more robust when scanning the entire workspace, though.