Skip to content

/ go

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

crypto/tls: Dial doesn't allow a non-default tls.Config to be used. #1248

Closed
fluffle opened this issue Nov 3, 2010 · 2 comments
Closed

crypto/tls: Dial doesn't allow a non-default tls.Config to be used. #1248

fluffle opened this issue Nov 3, 2010 · 2 comments
Labels
FrozenDueToAge

Comments

@fluffle
Copy link

@fluffle fluffle commented Nov 3, 2010 

Which revision are you using?  (hg identify)
$ hg identify
be428b51bf77+ tip

Please provide any additional information below.
http://golang.org/cl/2883041

The above patch will cause API breakage, but was the simplest implementation. I note
that Listen and NewListener both take *Config args.

This is useful for e.g. allowing clients to select non-default CA cert paths (or turn
off CA verification altogether) without having to re-implement most of tls.Dial()
themselves.
@adg

This comment has been minimized.

Sign in to view
Copy link
Contributor

@adg adg commented Nov 22, 2010

Comment 1:

Seems like a reasonable request.
To kick off the review process, please "hg mail" that CL.
Also, please add "Fixes issue #1248." to the CL description ("hg change").

Labels changed: added packagechange.

Status changed to Started.
@rsc

This comment has been minimized.

Sign in to view
Copy link
Contributor

@rsc rsc commented Dec 7, 2010

Comment 2:

This issue was closed by revision b15c424.

Status changed to Fixed.
@fluffle fluffle added fixed labels Dec 7, 2010
@mikioh mikioh changed the title [PATCH] tls.Dial() doesn't allow a non-default tls.Config to be used. crypto/tls: Dial doesn't allow a non-default tls.Config to be used. Jan 14, 2015
@golang golang locked and limited conversation to collaborators Jun 24, 2016
FiloSottile pushed a commit to FiloSottile/go that referenced this issue Oct 12, 2018
@rsc
crypto/tls: add *Config argument to Dial
f98d01f 
Document undocumented exported names.
Allow nil Rand, Time, RootCAs in Config.

Fixes golang#1248.

R=agl1
CC=golang-dev
https://golang.org/cl/3481042
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
@fluffle @adg @rsc @gopherbot
You can’t perform that action at this time.