New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/build: bring back "broke the build" notifications #12509

Open
josharian opened this Issue Sep 5, 2015 · 7 comments

Comments

Projects
None yet
6 participants
@josharian
Contributor

josharian commented Sep 5, 2015

I monitor the dev.ssa dashboard for build failures, with decreasing frequency these days. It'd be nice to bring back the automatic notification.

cc @bradfitz

@rsc

This comment has been minimized.

Contributor

rsc commented Oct 23, 2015

Sure would be nice!

@rsc rsc added this to the Go1.6 milestone Oct 23, 2015

@bradfitz bradfitz added the Builders label Oct 30, 2015

@bradfitz

This comment has been minimized.

Member

bradfitz commented Oct 30, 2015

@rsc, how is this a Go1.6 issue? It's not released with Go.

In any case, it's not exactly clear how this should work. Should a flake make it fire? Do you need N failures in a row first? What if the N failures in a row are different? How do you detect they're different? Parsing the text?

The easiest thing is to ignore flakes and just say any transition from ok to failure emails.

I suppose the coordinator could poll http://build.golang.org/?mode=json occasionally and post to Gerrit (which emails), since the coordinator already can post to Gerrit. By asking for the data from build.golang.org it would also catch builders like old-style builders like netbsd and solaris, which report directly to build.golang.org.

I'd prefer if people just don't break the build, though, so I've been spending my builder time primarily on making trybots better.

I'm happy to review code to resurrect this, though. I'm not sure where it lives before, or if it even makes sense to reuse any of the code. @adg?

@adg

This comment has been minimized.

Contributor

adg commented Oct 30, 2015

The code is already there in the build dashboard, it's just broken and I
haven't had an opportunity to investigate why.

On 31 October 2015 at 03:25, Brad Fitzpatrick notifications@github.com
wrote:

@rsc https://github.com/rsc, how is this a Go1.6 issue? It's not
released with Go.

In any case, it's not exactly clear how this should work. Should a flake
make it fire? Do you need N failures in a row first? What if the N failures
in a row are different? How do you detect they're different? Parsing the
text?

The easiest thing is to ignore flakes and just say any transition from ok
to failure emails.

I suppose the coordinator could poll http://build.golang.org/?mode=json
occasionally and post to Gerrit (which emails), since the coordinator
already can post to Gerrit. By asking for the data from build.golang.org
it would also catch builders like old-style builders like netbsd and
solaris, which report directly to build.golang.org.

I'd prefer if people just don't break the build, though, so I've been
spending my builder time primarily on making trybots better.

I'm happy to review code to resurrect this, though. I'm not sure where it
lives before, or if it even makes sense to reuse any of the code. @adg
https://github.com/adg?


Reply to this email directly or view it on GitHub
#12509 (comment).

@rsc

This comment has been minimized.

Contributor

rsc commented Dec 5, 2015

Would still like this, and it would have potentially sped the work on Go 1.6, but too late now and obviously not going to gate Go 1.6.

@rsc rsc modified the milestones: Unreleased, Go1.6 Dec 5, 2015

@bradfitz bradfitz changed the title from build: bring back "broke the build" notifications to x/build: bring back "broke the build" notifications Jul 7, 2017

@josharian

This comment has been minimized.

Contributor

josharian commented Mar 28, 2018

@andybons

This comment has been minimized.

Member

andybons commented Mar 30, 2018

Indeed this would be nice.

@FiloSottile

This comment has been minimized.

Member

FiloSottile commented May 15, 2018

This would be useful both for the dev branches and for the subrepos (so we are notified when master breaks x/crypto or x/crypto breaks on 1.9).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment