Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
x/build: bring back "broke the build" notifications #12509
@rsc, how is this a Go1.6 issue? It's not released with Go.
In any case, it's not exactly clear how this should work. Should a flake make it fire? Do you need N failures in a row first? What if the N failures in a row are different? How do you detect they're different? Parsing the text?
The easiest thing is to ignore flakes and just say any transition from ok to failure emails.
I suppose the coordinator could poll http://build.golang.org/?mode=json occasionally and post to Gerrit (which emails), since the coordinator already can post to Gerrit. By asking for the data from build.golang.org it would also catch builders like old-style builders like netbsd and solaris, which report directly to build.golang.org.
I'd prefer if people just don't break the build, though, so I've been spending my builder time primarily on making trybots better.
I'm happy to review code to resurrect this, though. I'm not sure where it lives before, or if it even makes sense to reuse any of the code. @adg?
The code is already there in the build dashboard, it's just broken and I
On 31 October 2015 at 03:25, Brad Fitzpatrick firstname.lastname@example.org
This could even be in cmd/gopherbot (which is easy to hack on locally), looking at the build.golang.org failure results and trying to not spam too early and waiting until it's confident (e.g. make.bash failing is a real failure, but a test failure might be a flake unless we saw in N times in a row).
Look at x/build/cmd/retrybuilds for code that accesses the build.golang.org failure results.
It hasn't worked in years. This is part of a series of CLs to clean up the build.golang.org App Engine app in prep for it to be modernized, refactored, and replaced. Updates golang/go#34744 Updates golang/go#12509 Change-Id: I9f8445046961ccbe97f7b9c85c0772393bf7d547 Reviewed-on: https://go-review.googlesource.com/c/build/+/208322 Reviewed-by: Bryan C. Mills <email@example.com> Reviewed-by: Andrew Gerrand <firstname.lastname@example.org>