Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/cmd/present: browser fullscreen mode wish #12634

Open
kaihendry opened this issue Sep 16, 2015 · 6 comments · May be fixed by golang/tools#31
Open

x/tools/cmd/present: browser fullscreen mode wish #12634

kaihendry opened this issue Sep 16, 2015 · 6 comments · May be fixed by golang/tools#31
Labels
NeedsFix The path to resolution is known, but the work has not been done. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone
Unreleased

Comments

@kaihendry
Copy link

On large displays present shows almost half of the next slide which can be distracting. Could there be a fullscreen mode please?
@rsc rsc added this to the Unreleased milestone Oct 23, 2015
lucor added a commit to lucor/tools that referenced this issue Mar 21, 2018
@lucor
tools/present: add support for full screen mode
1c65b8c 
This commit add the -fullscreen flag to enable full screen mode (default: false).
When enabled all the slides except the current one are hidden.

Fixes golang/go#12634 and golang/go#18299

Change-Id: Id2237aa938bdc7478e2072817e7abf2b7865dea8
@lucor lucor linked a pull request Mar 21, 2018 that will close this issue
Open
@gopherbot
Copy link
Contributor

Change https://golang.org/cl/101956 mentions this issue: tools/present: add support for full screen mode

@andybons andybons added the NeedsFix The path to resolution is known, but the work has not been done. label Mar 21, 2018
@zo0o0ot
Copy link

zo0o0ot commented Jul 19, 2018 •
edited
Loading

Trying to run with the fullscreen flag has this error:

flag provided but not defined: -fullscreen

Will there be communication as to which (future) version will have this feature?

@fabriziomoscon
Copy link

I think the code is here: golang/tools#31
but not merged yet

@gopherbot gopherbot added the Tools This label describes issues relating to any tools in the x/tools repository. label Sep 12, 2019
@henvic
Copy link
Contributor

henvic commented Mar 14, 2021

Hi, any updates on this? Would be very useful :)

@seankhliao seankhliao changed the title x/tools/go/present: browser fullscreen mode wish x/tools/cmd/present: browser fullscreen mode wish Oct 16, 2021
yuvalk pushed a commit to yuvalk/tools that referenced this issue Dec 20, 2021
@lucor
tools/present: add support for full screen mode
7a7cea4 
This commit add the -fullscreen flag to enable full screen mode (default: false).
When enabled all the slides except the current one are hidden.

Fixes golang/go#12634 and golang/go#18299

Change-Id: Id2237aa938bdc7478e2072817e7abf2b7865dea8
@stlaz
Copy link

stlaz commented Jun 29, 2023

You can actually supply your own styles to the tool and so you might be able to get the fullscreen even without the proposed patch.

I also consider the text in other slides to be distracting, and so after some weeping and gnashing of teeth I came up with https://github.com/talks-and-stuff/go-present-styles. I'm gonna leave it here in case somebody in the future finds it useful.

@gopherbot
Copy link
Contributor

Change https://go.dev/cl/586375 mentions this issue: present: add feature toggle for fullscreen mode

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
NeedsFix The path to resolution is known, but the work has not been done. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
None yet
Milestone
Unreleased
Development

Successfully merging a pull request may close this issue.

present: add support for full screen mode lucor/tools
8 participants
@rsc @andybons @stlaz @fabriziomoscon @kaihendry @zo0o0ot @henvic @gopherbot