Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/link: fail when -buildmode requires external linking but -linkmode=internal is passed #12848

Closed
mwhudson opened this issue Oct 6, 2015 · 3 comments

Comments

Projects
None yet
5 participants
@mwhudson
Copy link
Contributor

commented Oct 6, 2015

Currently if you pass a buildmode that requires external linking (e.g. shared) but explicitly request internal linking, -linkdmode=internal is ignored. It should probably error instead.

@rakyll rakyll added this to the Go1.6 milestone Oct 6, 2015

@rsc

This comment has been minimized.

Copy link
Contributor

commented Nov 5, 2015

OK

@rsc rsc modified the milestones: Go1.6Maybe, Go1.6 Dec 17, 2015

@rsc

This comment has been minimized.

Copy link
Contributor

commented Jan 6, 2016

@mwhudson, if you want to do this, sounds good to me. I just looked and I can't see where linkmode=internal is ignored.

@rsc rsc modified the milestones: Go1.7, Go1.6Maybe Jan 13, 2016

@rsc rsc modified the milestones: Go1.8, Go1.7 May 17, 2016

@crawshaw crawshaw self-assigned this Sep 16, 2016

@gopherbot

This comment has been minimized.

Copy link

commented Sep 16, 2016

CL https://golang.org/cl/28971 mentions this issue.

@gopherbot gopherbot closed this in 6007c8c Sep 16, 2016

@golang golang locked and limited conversation to collaborators Sep 16, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.