-
Notifications
You must be signed in to change notification settings - Fork 17.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
proposal: x/sys: add posix tc... functions #12853
Comments
SGTM
|
Adding constant definitions sounds good to me But those tc* functions are syscalls, but wrappers The API surface for x/sys/unix is already too large, That said, adding those tc* functions to Solaris |
If people think it is a good thing to place the tc* functions in a separate package for one GOOS/GOARCH combination, I would think it makes sense to do it for all supported GOOS/GOARCH combinations. My question is would it be x/sys/unix/termios or x/sys/termios. I believe Plan9 and Windows have these functions available so would think the package wouldn't go under x/sys/unix. |
My suggestion is sys/term which encompasses terminal like things across all Thanks Dave On Thu, Oct 8, 2015 at 2:50 AM, Kim Shrier notifications@github.com wrote:
|
I think we can decline this in favor of #13104 (not that 13104 is completely decided yet). x/sys really is about system calls and the line has to be drawn there. Otherwise x/sys will become a kitchen sink. |
Continuing along the lines of adding terminal support, I propose to add the functions:
Along with constant definitions for:
The source changes are fairly trivial and I have tested them for solaris. Adding this code to x/sys/unix means that you don't need to have cgo code in a higher level terminal package.
The text was updated successfully, but these errors were encountered: