Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

net/http: Malformed HTTP status code #12856

Closed
c4milo opened this issue Oct 6, 2015 · 4 comments

Comments

Projects
None yet
4 participants
@c4milo
Copy link
Member

commented Oct 6, 2015

Test code to reproduce the issue can be found at https://github.com/c4milo/gofetch. This one only happens consistently in Go 1.4.x. I couldn't reproduce it in Go 1.5.1

@adg

This comment has been minimized.

Copy link
Contributor

commented Oct 6, 2015

Have you tested it against Go 1.4.3?

@adg adg changed the title Malformed HTTP status code net/http: Malformed HTTP status code Oct 6, 2015

@c4milo

This comment has been minimized.

Copy link
Member Author

commented Oct 6, 2015

Yes, same result.

@c4milo

This comment has been minimized.

Copy link
Member Author

commented Oct 6, 2015

I just saw it happening in Go 1.5.1. But, I can't reproduce reliably.

@bradfitz

This comment has been minimized.

Copy link
Member

commented Oct 6, 2015

That code has many missed error checks. You're also copying the value of mutexes.

This has enough red flags that this is user error that I'm going to close this report for now. If you have something with complete error checks, no races, and ideally self-containing and easy for me to run and reproduce I can look into it more.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.