Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/crypto/ssh: TerminalModes have no impact on Session.RequestPty #12878

Open
sethamclean opened this issue Oct 8, 2015 · 2 comments
Open

x/crypto/ssh: TerminalModes have no impact on Session.RequestPty #12878

sethamclean opened this issue Oct 8, 2015 · 2 comments
Milestone

Comments

@sethamclean
Copy link

@sethamclean sethamclean commented Oct 8, 2015

modes := ssh.TerminalModes{
    ssh.ECHO: 0,
    ssh.ECHOCTL: 0,
    ssh.TTY_OP_ISPEED: 14400,
    ssh.TTY_IP_SPEED: 14400,
}
session.RequestPty("xterm", 80, 40, modes)

Control characters are still echoed and tab does not appear to trigger autocompletion in bash.

@sethamclean sethamclean changed the title golang.org/x/crypto/ssh: TerminalModes have no impact on Session.RequestPty x/crypto/ssh: TerminalModes have no impact on Session.RequestPty Oct 8, 2015
@ianlancetaylor ianlancetaylor added this to the Unreleased milestone Oct 8, 2015
@jalbai
Copy link

@jalbai jalbai commented Apr 6, 2016

I have the same issue

@stapelberg
Copy link
Contributor

@stapelberg stapelberg commented Mar 7, 2020

I don’t know about the TerminalModes not being effective and am equally confused about that.

However, for tab completion and control characters to work, you need a terminal.MakeRaw call. See https://stackoverflow.com/a/37088088/712014 for an example

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.