x/crypto/ssh: TerminalModes have no impact on Session.RequestPty

[sethamclean]

modes := ssh.TerminalModes{
    ssh.ECHO: 0,
    ssh.ECHOCTL: 0,
    ssh.TTY_OP_ISPEED: 14400,
    ssh.TTY_IP_SPEED: 14400,
}
session.RequestPty("xterm", 80, 40, modes)

Control characters are still echoed and tab does not appear to trigger autocompletion in bash.

[jalbai]

I have the same issue

[stapelberg]

I don’t know about the TerminalModes not being effective and am equally confused about that.

However, for tab completion and control characters to work, you need a terminal.MakeRaw call. See https://stackoverflow.com/a/37088088/712014 for an example