Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go/types: race-y initialization of Struct.offsets #12887

Closed
mdempsky opened this issue Oct 9, 2015 · 2 comments
Closed

go/types: race-y initialization of Struct.offsets #12887

mdempsky opened this issue Oct 9, 2015 · 2 comments
Assignees
Milestone

Comments

@mdempsky
Copy link
Member

@mdempsky mdempsky commented Oct 9, 2015

This program doesn't seem to violate any documented constraints of the go/types package, but it fails under the race detector because of the "compute offsets on demand" code in go/types.(*StdSizes).Sizeof: http://play.golang.org/p/VI2ablwxtX

@griesemer
Copy link
Contributor

@griesemer griesemer commented Oct 9, 2015

See also comment at go/types/type.go:125.

Loading

@gopherbot
Copy link

@gopherbot gopherbot commented Oct 20, 2015

CL https://golang.org/cl/16013 mentions this issue.

Loading

@rsc rsc added this to the Go1.6 milestone Oct 23, 2015
@griesemer griesemer closed this in a4cd0a4 Dec 1, 2015
@golang golang locked and limited conversation to collaborators Dec 1, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants