Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/net/http2: limit on sum of header block fragments #12916

Closed
bradfitz opened this issue Oct 13, 2015 · 1 comment
Closed

x/net/http2: limit on sum of header block fragments #12916

bradfitz opened this issue Oct 13, 2015 · 1 comment
Assignees
Milestone

Comments

@bradfitz
Copy link
Contributor

@bradfitz bradfitz commented Oct 13, 2015

We need a limit on the sum of header block fragments.

i.e. hpack.Decoder's saveBuf shouldn't grow too large. Perhaps if it gets to 1MB we just close the connection.

/cc @abursavich

@bradfitz bradfitz self-assigned this Oct 13, 2015
@bradfitz bradfitz added this to the Go1.6 milestone Oct 13, 2015
@gopherbot

This comment has been minimized.

Copy link

@gopherbot gopherbot commented Oct 14, 2015

CL https://golang.org/cl/15821 mentions this issue.

@golang golang locked and limited conversation to collaborators Oct 17, 2016
c3mb0 pushed a commit to c3mb0/net that referenced this issue Apr 2, 2018
Fixes golang/go#12916

Change-Id: I085ebc1d3f851d7c1b689a715c4f2fe85be4608a
Reviewed-on: https://go-review.googlesource.com/15821
Reviewed-by: Andrew Gerrand <adg@golang.org>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.