Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/build: upgrade OpenBSD GCE image #13029

Closed
mdempsky opened this issue Oct 23, 2015 · 7 comments

Comments

Projects
None yet
4 participants
@mdempsky
Copy link
Member

commented Oct 23, 2015

OpenBSD 5.8 was released on Oct 18, 2015, which means OpenBSD 5.6 is no longer supported upstream. We should upgrade the builder images to 5.7. (I'm assuming we prefer to continue testing on the oldest supported version.)

CC @bradfitz @adg @4a6f656c

@mdempsky mdempsky added the Builders label Oct 23, 2015

@mdempsky mdempsky self-assigned this Oct 23, 2015

@mdempsky mdempsky added this to the Unreleased milestone Oct 23, 2015

@gopherbot

This comment has been minimized.

Copy link

commented Oct 23, 2015

CL https://golang.org/cl/16238 mentions this issue.

@bradfitz

This comment has been minimized.

Copy link
Member

commented Oct 30, 2015

So what's the plan? We drop 5.6 and only test 5.7? Or test both 5.7 and 5.8?

@mdempsky

This comment has been minimized.

Copy link
Member Author

commented Oct 30, 2015

I was assuming drop 5.6 and only test 5.7. I'm happy to also prepare builder image scripts for 5.8, just I figured there probably aren't enough Go-relevant differences to merit additional GCE budget.

@bradfitz

This comment has been minimized.

Copy link
Member

commented Oct 30, 2015

I'm not paying for it.

@4a6f656c

This comment has been minimized.

Copy link
Contributor

commented Jan 7, 2016

The OpenBSD builders should just run the most current stable release (5.8 at this point in time) - this is how they've been run (at least prior to moving to GCE). The most important thing to verify is that we are able to build on the most recent release. If for some reason we stopped working on the previous stable release and someone wants to run Go tip, then they can upgrade.

@gopherbot

This comment has been minimized.

Copy link

commented Jan 7, 2016

CL https://golang.org/cl/18358 mentions this issue.

gopherbot pushed a commit to golang/build that referenced this issue Jan 24, 2016

env: update openbsd-{386,amd64} builder images to OpenBSD 5.8
OpenBSD 5.8 is the current release and OpenBSD 5.6 is no longer supported.

Revise build script:

- Use the auto installer and disklabel templates built into later versions of
  OpenBSD, rather than entirely using expect.

- Rather than duplicating the entire script for openbsd-386, provide an ARCH
  environment variable that switches between openbsd/amd64 and openbsd/i386.
  Have the openbsd-386 script invoke the openbsd-amd64 script with the
  appropriate environment.

- Remove the 'ignore classless-static-routes' option for dhclient, as it is
  no longer needed for OpenBSD 5.7 and later.

- Clean up after ourselves, rather than leaving a bunch of temporary files
  lying around.

Updates issue golang/go#13029.

Change-Id: Ic1b11dd5eded317b7be32b8f1c2485617ac02b78
Reviewed-on: https://go-review.googlesource.com/18358
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
@mdempsky

This comment has been minimized.

Copy link
Member Author

commented Jan 26, 2016

I think this is done now. The openbsd/386 and openbsd/amd64 builders are now running OpenBSD 5.8.

@mdempsky mdempsky closed this Jan 26, 2016

@golang golang locked and limited conversation to collaborators Feb 3, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.