Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/build/cmd/release: do not ship cmd/api binary #13030

Closed
rsc opened this issue Oct 23, 2015 · 1 comment
Closed

x/build/cmd/release: do not ship cmd/api binary #13030

rsc opened this issue Oct 23, 2015 · 1 comment
Assignees
Milestone

Comments

@rsc
Copy link
Contributor

@rsc rsc commented Oct 23, 2015

"go tool api" exists for our own internal quality control. It is not a general tool for others to use. It is likely being shipped in the binary distributions just because it gets built like anything else and is needed for all.bash.

The binary distribution packager should remove the cmd/api binary
from the list of files actually packed up. Not having it will make clearer to users that they should not use it.

(Go 1 compatiblity says nothing about tools, so the fact that we shipped one before doesn't matter.)

See CL 15140 for an example of someone thinking it's a general tool.

/cc @bradfitz

@bradfitz bradfitz added this to the Go1.6 milestone Oct 23, 2015
@bradfitz bradfitz self-assigned this Oct 23, 2015
@adg adg changed the title dist: do not ship cmd/api binary x/build/cmd/release: do not ship cmd/api binary Oct 23, 2015
@gopherbot
Copy link

@gopherbot gopherbot commented Nov 11, 2015

CL https://golang.org/cl/16802 mentions this issue.

@golang golang locked and limited conversation to collaborators Nov 16, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.