Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/build/cmd/coordinator: make all logs URLs permanent #13076

Closed
bradfitz opened this issue Oct 28, 2015 · 2 comments

Comments

@bradfitz
Copy link
Member

commented Oct 28, 2015

No matter what scary text I put in the URL, people still link to farmer.golang.org's emphemeral build logs.

Perhaps farmer.golang.org should start recording all its streamed state to GCS and make sure that all emphemeral build log URLs have enough information in them to fetch the old logs from GCS if the build is not currently in progress.

@bradfitz bradfitz added the Builders label Oct 28, 2015

@bradfitz bradfitz self-assigned this Oct 28, 2015

@bradfitz bradfitz added this to the Unreleased milestone Oct 28, 2015

@gopherbot

This comment has been minimized.

Copy link

commented Apr 13, 2016

CL https://golang.org/cl/21968 mentions this issue.

gopherbot pushed a commit to golang/build that referenced this issue Apr 13, 2016
cmd/coordinator: give each build and try set a globally unique random ID
These IDs will become the cloud datastore keys for keeping history and logs.

Many more CLs will follow: changing farmer URLs, logging to datastore,
fetching old logs from datastore, etc.

Updates golang/go#13076 (make all logs URLs permanent)
Updates golang/go#12669 (collect logs, stats)

Change-Id: I5b9fd21bf23581c59724b0ed32c8459baa9683f7
Reviewed-on: https://go-review.googlesource.com/21968
Reviewed-by: Andrew Gerrand <adg@golang.org>

@dmitshur dmitshur changed the title x/build/coordinator: make all logs URLs permanent x/build/cmd/coordinator: make all logs URLs permanent Jun 19, 2019

@dmitshur

This comment has been minimized.

Copy link
Member

commented Sep 5, 2019

I'll close this 2015 issue in favor of #34119, which supersedes it.

This issue describes fairly low level implementation details, and coordinator may have changed since 2015. We can open new specific issues to track this work as needed.

@dmitshur dmitshur closed this Sep 5, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.