x/net/http2: data race in Server

[bmizerany]

Running tests with -race consistent yields:

$ go test -race
==================
WARNING: DATA RACE
Read by goroutine 64:
  golang.org/x/net/http2.(*writeScheduler).take()
      /Users/bmizerany/src/golang.org/x/net/http2/writesched.go:123 +0x3af
  golang.org/x/net/http2.(*serverConn).scheduleFrameWrite()
      /Users/bmizerany/src/golang.org/x/net/http2/server.go:916 +0x3ab
  golang.org/x/net/http2.(*serverConn).writeFrame()
      /Users/bmizerany/src/golang.org/x/net/http2/server.go:802 +0xa2
  golang.org/x/net/http2.(*serverConn).serve()
      /Users/bmizerany/src/golang.org/x/net/http2/server.go:674 +0xb90
  golang.org/x/net/http2.(*Server).handleConn()
      /Users/bmizerany/src/golang.org/x/net/http2/server.go:282 +0xf93
  golang.org/x/net/http2.ConfigureServer.func1()
      /Users/bmizerany/src/golang.org/x/net/http2/server.go:193 +0xc4
  net/http.(*conn).serve()
      /usr/local/go/src/net/http/server.go:1312 +0x9ce

Previous write by goroutine 15:
  golang.org/x/net/http2.(*responseWriterState).writeChunk()
      /Users/bmizerany/src/golang.org/x/net/http2/server.go:1770 +0x4f4
  golang.org/x/net/http2.(*responseWriter).Flush()
      /Users/bmizerany/src/golang.org/x/net/http2/server.go:1793 +0x140
  golang.org/x/net/http2.(*responseWriter).handlerDone()
      /Users/bmizerany/src/golang.org/x/net/http2/server.go:1893 +0xc6
  golang.org/x/net/http2.(*serverConn).runHandler()
      /Users/bmizerany/src/golang.org/x/net/http2/server.go:1526 +0x94

Goroutine 64 (running) created at:
  net/http.(*Server).Serve()
      /usr/local/go/src/net/http/server.go:1910 +0x464

Goroutine 15 (finished) created at:
  golang.org/x/net/http2.(*serverConn).processHeaderBlockFragment()
      /Users/bmizerany/src/golang.org/x/net/http2/server.go:1384 +0x6ad
  golang.org/x/net/http2.(*serverConn).processHeaders()
      /Users/bmizerany/src/golang.org/x/net/http2/server.go:1328 +0x83a
  golang.org/x/net/http2.(*serverConn).processFrame()
      /Users/bmizerany/src/golang.org/x/net/http2/server.go:1048 +0x718
  golang.org/x/net/http2.(*serverConn).processFrameFromReader()
      /Users/bmizerany/src/golang.org/x/net/http2/server.go:998 +0xb96
  golang.org/x/net/http2.(*serverConn).serve()
      /Users/bmizerany/src/golang.org/x/net/http2/server.go:678 +0xd15
  golang.org/x/net/http2.(*Server).handleConn()
      /Users/bmizerany/src/golang.org/x/net/http2/server.go:282 +0xf93
  golang.org/x/net/http2.ConfigureServer.func1()
      /Users/bmizerany/src/golang.org/x/net/http2/server.go:193 +0xc4
  net/http.(*conn).serve()
      /usr/local/go/src/net/http/server.go:1312 +0x9ce
==================
PASS
Found 1 data race(s)
exit status 66
FAIL    golang.org/x/net/http2  10.220s

[gopherbot]

CL https://golang.org/cl/16465 mentions this issue.

[gopherbot]

CL https://golang.org/cl/16490 mentions this issue.