Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: builders for alternate buildmodes? #13136

Open
crawshaw opened this issue Nov 3, 2015 · 4 comments
Open

build: builders for alternate buildmodes? #13136

crawshaw opened this issue Nov 3, 2015 · 4 comments
Labels
Milestone

Comments

@crawshaw
Copy link
Contributor

@crawshaw crawshaw commented Nov 3, 2015

For -buildmode=shared on linux/386, @mwhudson's current set of patches would borrow the CX register. This seems reasonable to me, but means that assembly that works under -buildmode=exe will not work under -buildmode=shared (see the discussion on http://golang.org/cl/16385).

Should we have a builder that runs the standard library tests compiled with -buildmode=shared? What about c-shared and c-archive?

cc @ianlancetaylor @bradfitz

@mwhudson
Copy link
Contributor

@mwhudson mwhudson commented Nov 5, 2015

More automated testing of this sort of thing would definitely be a good thing. You can't just run "go test -buildmode=shared std" though because -buildmode=shared doesn't make an executable. I guess it would make sense to build a minimal libruntime.so and run tests for all std library things apart from runtime (you can't really say go test -linkshared foo when foo is built into a shared library).

Running go -test -buildmode=pie would be useful.

Something like https://go-review.googlesource.com/#/c/16343/ would be nice too.

@ianlancetaylor ianlancetaylor added this to the Unreleased milestone Nov 5, 2015
@bradfitz bradfitz added the Builders label Nov 5, 2015
@bradfitz
Copy link
Contributor

@bradfitz bradfitz commented Nov 5, 2015

I have no objections. Any concrete proposal for x/build/dashboard/builders.go etc?

@gopherbot
Copy link

@gopherbot gopherbot commented Nov 18, 2015

CL https://golang.org/cl/17032 mentions this issue.

@gopherbot
Copy link

@gopherbot gopherbot commented Nov 19, 2015

CL https://golang.org/cl/17051 mentions this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
5 participants
You can’t perform that action at this time.