Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/crypto/ssh: package does not compile with Go 1.3 or earlier #13137

Closed
davecheney opened this issue Nov 3, 2015 · 8 comments
Closed

x/crypto/ssh: package does not compile with Go 1.3 or earlier #13137

davecheney opened this issue Nov 3, 2015 · 8 comments
Assignees
Milestone

Comments

@davecheney
Copy link
Contributor

@davecheney davecheney commented Nov 3, 2015

https://go-review.googlesource.com/#/c/10953/ added support for converting from the crypto.Signer interface, added in Go 1.4 to an ssh.Signer.

This means the crypto package does not compile under Go 1.3 and earlier. This is a problem for Canonical as (for various long, but immutable reasons) we are stuck on Go 1.2 for several of the operating system versions we support.

@agl one solution to this is to isolate the change to keys.go into a file which is only built with Go 1.4 or later. This would hide this feature from Go versions which do not support crypto.Signer.

An alternative would be to define an interface in the ssh package that is compatible with crypto.Signer, and use that as the formal parameter to those new methods in keys.go

I think the former is a cleaner option. What do you think ?

@bradfitz
Copy link
Contributor

@bradfitz bradfitz commented Nov 3, 2015

Note that build.golang.org only tests subrepos against the past two releases (Go 1.4 and Go 1.5). Unless we change that policy, you're fighting an uphill battle trying to get tip working with Go 1.3.

/cc @adg

@davecheney
Copy link
Contributor Author

@davecheney davecheney commented Nov 3, 2015

Thanks. I appreciate that canonical have bought this on themselves.

On Wed, 4 Nov 2015, 08:27 Brad Fitzpatrick notifications@github.com wrote:

Note that build.golang.org only tests subrepos against the past two
releases (Go 1.4 and Go 1.5). Unless we change that policy, you're fighting
an uphill battle trying to get tip working with Go 1.3.

/cc @adg https://github.com/adg


Reply to this email directly or view it on GitHub
#13137 (comment).

@rakyll
Copy link
Contributor

@rakyll rakyll commented Nov 3, 2015

It's better to move this conversation to a mailing list since it cannot be considered as a Go issue.

@rakyll rakyll closed this Nov 3, 2015
@davecheney
Copy link
Contributor Author

@davecheney davecheney commented Nov 3, 2015

Respectfully, I disagree with this assessment.

On Wed, 4 Nov 2015, 09:42 Burcu Dogan notifications@github.com wrote:

It's better to move this conversation to a mailing list since it cannot be
considered as a Go issue.


Reply to this email directly or view it on GitHub
#13137 (comment).

@rakyll rakyll reopened this Nov 3, 2015
@bradfitz
Copy link
Contributor

@bradfitz bradfitz commented Nov 3, 2015

Either way. Or use both. I don't feel strongly about github issue vs mailing list here. Up to ssh authors. This bug tracker is more than just the Go stdlib, though.

The policy issue of support lifetime for sub repos might make a good mailing list topic

@agl
Copy link
Contributor

@agl agl commented Nov 4, 2015

Moving some of the code into a separate file sounds fine to me. I'm hesitant to make any commitments about backwards compatibility in general, but this seems like a minor change that would be useful to someone.

@ianlancetaylor ianlancetaylor added this to the Unreleased milestone Nov 5, 2015
@agl agl assigned agl and davecheney and unassigned agl Nov 14, 2015
@agl
Copy link
Contributor

@agl agl commented Nov 15, 2015

Assigning this to Dave so that he can craft something that works in a Go 1.3 environment.

@davecheney
Copy link
Contributor Author

@davecheney davecheney commented Nov 16, 2015

@agl after a bit of wrangling internally we're going to try to upgrade to Go 1.5 instead. Given @bradfitz 's points that this change won't be tested by the buildbots, I'd prefer to close this issue instead.

@davecheney davecheney closed this Nov 16, 2015
@golang golang locked and limited conversation to collaborators Nov 16, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
6 participants
You can’t perform that action at this time.