Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
GitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
x/crypto/ssh: package does not compile with Go 1.3 or earlier #13137
https://go-review.googlesource.com/#/c/10953/ added support for converting from the crypto.Signer interface, added in Go 1.4 to an ssh.Signer.
This means the crypto package does not compile under Go 1.3 and earlier. This is a problem for Canonical as (for various long, but immutable reasons) we are stuck on Go 1.2 for several of the operating system versions we support.
@agl one solution to this is to isolate the change to keys.go into a file which is only built with Go 1.4 or later. This would hide this feature from Go versions which do not support crypto.Signer.
An alternative would be to define an interface in the ssh package that is compatible with crypto.Signer, and use that as the formal parameter to those new methods in keys.go
I think the former is a cleaner option. What do you think ?
Thanks. I appreciate that canonical have bought this on themselves.
On Wed, 4 Nov 2015, 08:27 Brad Fitzpatrick email@example.com wrote: