Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

net/http: verify and test that Request.Cancel interrupts bodies too #13159

Closed
bradfitz opened this issue Nov 5, 2015 · 2 comments

Comments

Projects
None yet
2 participants
@bradfitz
Copy link
Member

commented Nov 5, 2015

Verify that the Transport (both http1 and http2) interrupts a body read if Request.Cancel becomes readable.

Motivation was from https://go-review.googlesource.com/#/c/16101/5..7/kubernetes/client.go

@bradfitz bradfitz self-assigned this Nov 5, 2015

@bradfitz bradfitz added this to the Go1.6 milestone Nov 5, 2015

@gopherbot

This comment has been minimized.

Copy link

commented Dec 14, 2015

CL https://golang.org/cl/17758 mentions this issue.

@gopherbot

This comment has been minimized.

Copy link

commented Dec 14, 2015

CL https://golang.org/cl/17757 mentions this issue.

bradfitz added a commit to golang/net that referenced this issue Dec 14, 2015

http2: support Request.Cancel in Transport
Tests are in a separate change, part of the net/http package in the
main go repo.

Updates golang/go#13159

Change-Id: I236dea7cd076910e908df7e7160d490da56014c8
Reviewed-on: https://go-review.googlesource.com/17757
Reviewed-by: Ian Lance Taylor <iant@golang.org>

@bradfitz bradfitz closed this in e568a01 Dec 14, 2015

@golang golang locked and limited conversation to collaborators Dec 14, 2016

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.