Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
syscall: Getpagesize should consult OS on arm64 #13191
Comments
ianlancetaylor
added this to the Go1.6 milestone
Nov 9, 2015
rakyll
changed the title from
On AArch64 Getpagesize() can return wrong value
to
syscall: on aarch64 Getpagesize() can return wrong value
Nov 9, 2015
rsc
changed the title from
syscall: on aarch64 Getpagesize() can return wrong value
to
syscall: Getpagesize should consult OS on arm64
Nov 24, 2015
rsc
modified the milestones:
Unplanned,
Go1.6
Dec 5, 2015
dmcgowan
referenced this issue
in moby/moby
Oct 18, 2016
Closed
aarch64: build fails with TestOverlay128LayerRead #27384
dmcgowan
commented
Oct 19, 2016
|
This is causing an issue in Docker running on arm64 with the new overlay driver. We use the pagesize to determine when we the mount arguments are too large. It would be preferable to report the PageSize as the minimum value rather than the maximum to avoid unexpected truncation to syscalls. |
vielmetti
commented
Oct 19, 2016
|
Thanks @dmcgowan - good catch! |
vielmetti
commented
Oct 19, 2016
•
|
Oh, yeah, @aclements already did this in 1b9499b |
bradfitz
closed this
Oct 19, 2016
This was referenced Jan 13, 2017
Open
gopherbot
locked and limited conversation to collaborators
Oct 19, 2017
gopherbot
added
the
FrozenDueToAge
label
Oct 19, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
hrw commentedNov 9, 2015
There is code in src/syscall/syscall_linux_arm64.go file:
But this architecture supports three values for PAGE_SIZE: 4K, 16K and 64K which are selected at kernel compilation time.
Userspace is expected to check which value is set. Simplest solution is to use sysconf(_SC_PAGESIZE) function call (same as getpagesize()).