Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/link: remove text relocation from android/386 lib #13201

Closed
hyangah opened this issue Nov 10, 2015 · 9 comments

Comments

Projects
None yet
3 participants
@hyangah
Copy link
Contributor

commented Nov 10, 2015

-buildmode=pie
Various build tests are failing due to the error, and the newest androids will not be happy.

go_android_exec: adb shell mkdir -p /data/local/tmp/syscall.test-30583
go_android_exec: adb push /tmp/go-build252116514/syscall/_test/syscall.test /data/local/tmp/syscall.test-30583/syscall.test-30583-tmp
260 KB/s (3507788 bytes in 13.157s)
go_android_exec: adb shell cp '/data/local/tmp/syscall.test-30583/syscall.test-30583-tmp' '/data/local/tmp/syscall.test-30583/syscall.test-30583'
go_android_exec: adb shell rm '/data/local/tmp/syscall.test-30583/syscall.test-30583-tmp'
go_android_exec: adb shell export TMPDIR="/data/local/tmp/syscall.test-30583"; export GOROOT="/data/local/tmp/goroot"; export GOPATH="/data/local/tmp/gopath"; cd "/data/local/tmp/goroot/src/syscall"; '/data/local/tmp/syscall.test-30583/syscall.test-30583' -test.short=true -test.timeout=3m0s; echo -n exitcode=$?
WARNING: linker: /data/local/tmp/syscall.test-30583/syscall.test-30583 has text relocations. This is wasting memory and prevents security hardening. Please fix.
WARNING: linker: /data/local/tmp/syscall.test-30583/TestDeathSignal470352929/syscall.test-30583 has text relocations. This is wasting memory and prevents security hardening. Please fix.
--- FAIL: TestFcntlFlock (0.03s)
    syscall_unix_test.go:98: child process: "WARNING: linker: /data/local/tmp/syscall.test-30583/syscall.test-30583 has text relocations. This is wasting memory and prevents security hardening. Please fix.\n", 
--- FAIL: TestPassFD (0.03s)
    syscall_unix_test.go:166: child process: "WARNING: linker: /data/local/tmp/syscall.test-30583/syscall.test-30583 has text relocations. This is wasting memory and prevents security hardening. Please fix.\n", 
FAIL
exitcode=1go_android_exec: adb shell rm -rf /data/local/tmp/syscall.test-30583
FAIL    syscall 14.200s

@crawshaw

@hyangah hyangah added this to the Unreleased milestone Nov 10, 2015

@mwhudson

This comment has been minimized.

Copy link
Contributor

commented Nov 10, 2015

This is pretty non-trivial of course. I have stuff up for review in this direction, but it currently doesn't work for -buildmode=pie.

@mwhudson

This comment has been minimized.

Copy link
Contributor

commented Nov 11, 2015

I think I have something working for this (now just to bash it into something fit for review). How much do you care about performance for this stuff?

@hyangah

This comment has been minimized.

Copy link
Contributor Author

commented Nov 11, 2015

@mwhudson Great. I can say, for now, performance is secondary.

@mwhudson

This comment has been minimized.

Copy link
Contributor

commented Nov 11, 2015

That's good to hear :-)

@gopherbot

This comment has been minimized.

Copy link

commented Nov 17, 2015

CL https://golang.org/cl/17002 mentions this issue.

@mwhudson

This comment has been minimized.

Copy link
Contributor

commented Nov 17, 2015

I've just pushed a stack of changes ending with https://go-review.googlesource.com/16388 that I think should fix this. I'd love to hear if it in fact does :-)

@gopherbot

This comment has been minimized.

Copy link

commented Nov 18, 2015

CL https://golang.org/cl/17014 mentions this issue.

@hyangah

This comment has been minimized.

Copy link
Contributor Author

commented Nov 18, 2015

great. will check tomorrow. many thanks

On Tuesday, November 17, 2015, Michael Hudson-Doyle <
notifications@github.com> wrote:

I've just pushed a stack of changes ending with
https://go-review.googlesource.com/16388 that I think should fix this.
I'd love to hear if it in fact does :-)


Reply to this email directly or view it on GitHub
#13201 (comment).

__

@gopherbot gopherbot closed this in cb03938 Nov 18, 2015

@mwhudson

This comment has been minimized.

Copy link
Contributor

commented Nov 18, 2015

Oops, not sure that CL actually fixes this bug, sorry. Might want to reopen...

@golang golang locked and limited conversation to collaborators Nov 17, 2016

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.